Skip to content

Commit 24b0ba0

Browse files
authored
MRG: Merge pull request #533 from octue/devops/remove-git-mkver-file
Remove `mkver.conf` file and update troubleshooting docs
2 parents f0b1cab + 4b7ec8e commit 24b0ba0

13 files changed

+3471
-218
lines changed

.github/workflows/python-ci.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,10 @@ jobs:
1919
- uses: actions/checkout@v3
2020
with:
2121
fetch-depth: 0
22-
- uses: octue/[email protected]1
22+
- uses: octue/[email protected]3
2323
with:
24-
version_source_type: pyproject.toml
24+
path: pyproject.toml
25+
breaking_change_indicated_by: minor
2526

2627
run-tests:
2728
if: "!contains(github.event.head_commit.message, 'skipci')"

.github/workflows/update-pull-request.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,13 @@ jobs:
1818
runs-on: ubuntu-latest
1919
steps:
2020
- uses: actions/checkout@v3
21-
- uses: octue/[email protected]
21+
- uses: octue/[email protected]
22+
id: pr-description
2223
with:
2324
pull_request_url: ${{ github.event.pull_request.url }}
2425
api_token: ${{ secrets.GITHUB_TOKEN }}
2526
- name: Update pull request body
2627
uses: riskledger/update-pr-description@v2
2728
with:
28-
body: ${{ env.PULL_REQUEST_DESCRIPTION }}
29+
body: ${{ steps.pr-description.outputs.pull_request_description }}
2930
token: ${{ secrets.GITHUB_TOKEN }}

.pre-commit-config.yaml

Lines changed: 30 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
exclude: 'build|.git/|.tox|dist|octue.egg-info'
1+
exclude: "build|.git/|.tox|dist|octue.egg-info"
22
default_stages: [commit]
33
fail_fast: true
44
default_language_version:
5-
python: python3 # force all unspecified python hooks to run python3
5+
python: python3 # force all unspecified python hooks to run python3
66
repos:
77
- repo: https://github.com/pre-commit/pre-commit-hooks
88
rev: v4.3.0
@@ -21,55 +21,60 @@ repos:
2121
rev: 22.6.0
2222
hooks:
2323
- id: black
24-
args: ['--line-length', '120']
24+
args: ["--line-length", "120"]
2525

2626
- repo: https://gitlab.com/pycqa/flake8
2727
rev: 3.9.2
2828
hooks:
2929
- id: flake8
3030
language_version: python3
3131
additional_dependencies:
32-
- 'pep8-naming'
32+
- "pep8-naming"
3333
args:
3434
- --ignore-names=setUp,tearDown,setUpClass,tearDownClass,asyncSetUp,asyncTearDown,setUpTestData,failureException,longMessage,maxDiff,startTestRun,stopTestRun
3535

36+
- repo: https://github.com/pre-commit/mirrors-prettier
37+
rev: v2.7.1
38+
hooks:
39+
- id: prettier
40+
3641
- repo: https://github.com/pycqa/pydocstyle
3742
rev: 6.1.1
3843
hooks:
39-
- id: pydocstyle
44+
- id: pydocstyle
4045

4146
- repo: https://github.com/thclark/pre-commit-sphinx
4247
rev: 0.0.3
4348
hooks:
4449
- id: build-docs
4550
language_version: python3
4651
additional_dependencies:
47-
- 'poetry==1.2.0b2'
48-
- 'Sphinx>=4,<5'
49-
- 'sphinx-rtd-theme>=1,<2'
50-
- 'sphinx-tabs>=3,<4'
51-
- 'sphinx-toolbox==3.0.0'
52-
- 'git+https://github.com/octue/octue-sdk-python.git@main'
52+
- "poetry==1.2.0b2"
53+
- "Sphinx>=4,<5"
54+
- "sphinx-rtd-theme>=1,<2"
55+
- "sphinx-tabs>=3,<4"
56+
- "sphinx-toolbox==3.0.0"
57+
- "git+https://github.com/octue/octue-sdk-python.git@main"
5358

5459
- repo: https://github.com/windpioneers/pre-commit-hooks
5560
rev: 0.0.5
5661
hooks:
5762
- id: check-branch-name
5863
args:
59-
- '^main$'
60-
- '^development$'
61-
- '^devops/([a-z][a-z0-9]*)(-[a-z0-9]+)*$'
62-
- '^doc/([a-z][a-z0-9]*)(-[a-z0-9]+)*$'
63-
- '^feature/([a-z][a-z0-9]*)(-[a-z0-9]+)*$'
64-
- '^enhancement/([a-z][a-z0-9]*)(-[a-z0-9]+)*$'
65-
- '^fix/([a-z][a-z0-9]*)(-[a-z0-9]+)*$'
66-
- '^hotfix/([a-z][a-z0-9]*)(-[a-z0-9]+)*$'
67-
- '^review/([a-z][a-z0-9]*)(-[a-z0-9]+)*$'
68-
- '^refactor/([a-z][a-z0-9]*)(-[a-z0-9]+)*$'
69-
- '^test/([a-z][a-z0-9]*)(-[a-z0-9]+)*$'
70-
- '^style/([a-z][a-z0-9]*)(-[a-z0-9]+)*$'
71-
- '^deprecation/([a-z][a-z0-9]*)(-[a-z0-9]+)*$'
72-
- '^dependencies/([a-z][a-z0-9]*)(-[a-z0-9]+)*$'
64+
- "^main$"
65+
- "^development$"
66+
- "^devops/([a-z][a-z0-9]*)(-[a-z0-9]+)*$"
67+
- "^doc/([a-z][a-z0-9]*)(-[a-z0-9]+)*$"
68+
- "^feature/([a-z][a-z0-9]*)(-[a-z0-9]+)*$"
69+
- "^enhancement/([a-z][a-z0-9]*)(-[a-z0-9]+)*$"
70+
- "^fix/([a-z][a-z0-9]*)(-[a-z0-9]+)*$"
71+
- "^hotfix/([a-z][a-z0-9]*)(-[a-z0-9]+)*$"
72+
- "^review/([a-z][a-z0-9]*)(-[a-z0-9]+)*$"
73+
- "^refactor/([a-z][a-z0-9]*)(-[a-z0-9]+)*$"
74+
- "^test/([a-z][a-z0-9]*)(-[a-z0-9]+)*$"
75+
- "^style/([a-z][a-z0-9]*)(-[a-z0-9]+)*$"
76+
- "^deprecation/([a-z][a-z0-9]*)(-[a-z0-9]+)*$"
77+
- "^dependencies/([a-z][a-z0-9]*)(-[a-z0-9]+)*$"
7378

7479
- repo: https://github.com/octue/conventional-commits
7580
rev: 0.8.1

docs/source/asking_questions.rst

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ input values and/or an input manifest.
4747
from octue.resources import Child
4848
4949
child = Child(
50-
id="my-organisation/my-service",
50+
id="my-organisation/my-service:latest",
5151
backend={"name": "GCPPubSubBackend", "project_name": "my-project"},
5252
)
5353
@@ -122,15 +122,15 @@ if your app configuration file is:
122122
"children": [
123123
{
124124
"key": "wind_speed",
125-
"id": "template-child-services/wind-speed-service",
125+
"id": "template-child-services/wind-speed-service:latest",
126126
"backend": {
127127
"name": "GCPPubSubBackend",
128128
"project_name": "my-project"
129129
}
130130
},
131131
{
132132
"key": "elevation",
133-
"id": "template-child-services/elevation-service",
133+
"id": "template-child-services/elevation-service:latest",
134134
"backend": {
135135
"name": "GCPPubSubBackend",
136136
"project_name": "my-project"
@@ -183,15 +183,15 @@ For example, if the child requires these children in its app configuration:
183183
[
184184
{
185185
"key": "wind_speed",
186-
"id": "template-child-services/wind-speed-service",
186+
"id": "template-child-services/wind-speed-service:latest",
187187
"backend": {
188188
"name": "GCPPubSubBackend",
189189
"project_name": "octue-amy"
190190
},
191191
},
192192
{
193193
"key": "elevation",
194-
"id": "template-child-services/elevation-service",
194+
"id": "template-child-services/elevation-service:latest",
195195
"backend": {
196196
"name": "GCPPubSubBackend",
197197
"project_name": "octue-amy"
@@ -208,15 +208,15 @@ then you can override them like this:
208208
children=[
209209
{
210210
"key": "wind_speed",
211-
"id": "my/own-service",
211+
"id": "my/own-service:latest",
212212
"backend": {
213213
"name": "GCPPubSubBackend",
214214
"project_name": "octue-amy"
215215
},
216216
},
217217
{
218218
"key": "elevation",
219-
"id": "organisation/another-service",
219+
"id": "organisation/another-service:latest",
220220
"backend": {
221221
"name": "GCPPubSubBackend",
222222
"project_name": "octue-amy"

docs/source/creating_services.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ octue.yaml
115115
116116
services:
117117
- namespace: my-organisation
118-
- name: my-app
118+
name: my-app
119119
120120
It may also need the following key-value pairs:
121121

0 commit comments

Comments
 (0)