utils/calc: fix searching NUMA nodes inside CPU objects when NUMA are attached higher

This is the symmetric of the previous commit, but reversing NUMAs and PUs.

When a NUMA node is attached at a level, and we search for that NUMA node
inside children of that level (hierarchical spec), the cpuset of the NUMA
node contains more than just one children, hence we wouldn't find it
with isincluded(). We now use zero()||intersects() instead.

Example (different from the one added in test-hwloc-calc):
AMD machine with 4 L3 (4 cores each) and 1 NUMA per package (16 cores total).
"hwloc-calc l3:0.numa:0" should return the first NUMA (cpuset 0xffff nodeset 0x1)
but it didn't because it's not included in the L3 (cpuset 0x000f nodeset 0x1).

This should not happen when the user knows the ordering of levels in the machine,
but may happen when using generic scripts that don't know where NUMA is attached
(L3 above NUMA on some Intel/SNC but below on AMD currently).

Signed-off-by: Brice Goglin <[email protected]>

Author: bgoglin

utils/hwloc/hwloc-calc.h

@@ -86,7 +86,7 @@ hwloc_calc_get_nbobjs_inside_sets_by_depth(struct hwloc_calc_location_context_s
   hwloc_obj_t obj = NULL;
   unsigned n = 0;
   while ((obj = hwloc_get_next_obj_by_depth(topology, depth, obj)) != NULL) {
-    if (!hwloc_bitmap_isincluded(obj->cpuset, cpuset))
+    if (!hwloc_bitmap_iszero(obj->cpuset) && !hwloc_bitmap_intersects(obj->cpuset, cpuset))
       continue;
     if (!hwloc_bitmap_iszero(obj->nodeset) && !hwloc_bitmap_intersects(obj->nodeset, nodeset))
       continue;
@@ -115,7 +115,7 @@ hwloc_calc_get_obj_inside_sets_by_depth(struct hwloc_calc_location_context_s *lc
   hwloc_obj_t obj = NULL;
   unsigned i = 0;
   while ((obj = hwloc_get_next_obj_by_depth(topology, depth, obj)) != NULL) {
-    if (!hwloc_bitmap_isincluded(obj->cpuset, cpuset))
+    if (!hwloc_bitmap_iszero(obj->cpuset) && !hwloc_bitmap_intersects(obj->cpuset, cpuset))
       continue;
     if (!hwloc_bitmap_iszero(obj->nodeset) && !hwloc_bitmap_intersects(obj->nodeset, nodeset))
       continue;

utils/hwloc/test-hwloc-calc.output

@@ -133,6 +133,9 @@ PU:22_PU:23_Core:6_Core:7_Group0:2
 # Search cores within single NUMA when they have multiple local NUMA nodes
 0x00000060
 
+# Search NUMA node within single Group when they have multiple local Groups
+0x00000002
+
 # Physical output of NUMA Nodes when out-of-order in the topology
 2,1
 

utils/hwloc/test-hwloc-calc.sh.in

@@ -184,6 +184,9 @@ set -e
   echo "# Search cores within single NUMA when they have multiple local NUMA nodes"
   $calc --if synthetic --input "pack:2 [numa] [numa] core:4 pu:1" sock:1.numa:1.core:1-2
   echo
+  echo "# Search NUMA node within single Group when they have multiple local Groups"
+  $calc --if synthetic --input "pack:2 [numa] group:2 core:4 1" --nodeset-output pack:1.group:1.numa:0
+  echo
 
   echo "# Physical output of NUMA Nodes when out-of-order in the topology"
   $calc --if synthetic --input "node:4(indexes=3,2,1,0) pu:2" node:1-2 --po -I node