Skip to content

make check fails on windows with French locale #246

Open
@bgoglin

Description

@bgoglin

(imported from #75)
The XML output is still localized on Windows from what I see. make check even fails in tests/xml when running in French language (export LANG/LC_ALL in the test-topology script doesn't help).

lstopo calls setlocale("") for various reasons, which should pickup the locale config from the environment. However the Windows setlocale() just looks a the system config, not at env vars. So lstopo ignores LANG=C set in test scripts (at least tests/hwloc/xml), causing the output (floats) to be localized, and therefore different from the expected output. Floats in input XMLs are also not parsed correctly.

We could have yet another env var to force lstopo to setlocale("C") instead of setlocale("") during those tests.

For now, we build under Windows with the locale set to english.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions