Warnings in oshmem

[devreal]

Current git main shows a bunch of warnings in oshmem, coming from the the RUNTIME_CHECK_IMPL_RC macro:

../../../../oshmem/runtime/runtime.h:168:11: warning: comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘int’ [-Wsign-compare]
  168 |     if (x <= -1)                                                            \
      |           ^~
../../../../oshmem/shmem/c/shmem_test_ivars.c:206:9: note: in expansion of macro ‘RUNTIME_CHECK_IMPL_RC’
  206 |         RUNTIME_CHECK_IMPL_RC(rc);                                  \
      |         ^~~~~~~~~~~~~~~~~~~~~
../../../../oshmem/shmem/c/shmem_test_ivars.c:320:1: note: in expansion of macro ‘SHMEM_TYPE_TEST_SOME_VECTOR’
  320 | SHMEM_TYPE_TEST_SOME_VECTOR(_int32,  int32_t, SHMEM_INT32_T, shmem)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~

For x as size_t this check is dropped by the compiler, since x can never be smaller than -1 (size_t being unsigned).

There are functions that return size_t but the returned error value is an error (a negative value), e.g.,

size_t mca_spml_ucx_test_any(void *ivars, int cmp, void *cmp_value,
        size_t nelems, const int *status, int datatype)
{
    return OSHMEM_ERR_NOT_IMPLEMENTED;
}

Not sure how that is supposed to work...

[roiedanino]

Will look into it (can't assign myself for some reason)

[roiedanino]

@MamziB Any reason those functions should return size_t instead of int?

Otherwise, I will change those to return int to match other places where rc is returned.

[janjust]

fixed with #12648 in main, and #12671 in v5.0.x