fix: Add Missing Flags as Helm Values #3787
Conversation
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
Signed-off-by: Ian Stanton <[email protected]>
| volumeMounts: | ||
| - mountPath: /certs | ||
| name: cert | ||
| readOnly: true | ||
| $patch: delete |
There was a problem hiding this comment.
I added these here to avoid duplicate entries when generating manifests. I renamed the file as it is no longer only deleting ports.
| @@ -8,7 +8,7 @@ bases: | |||
| - "../../../config/default" | |||
| patchesStrategicMerge: | |||
| - kustomize-for-helm.yaml | |||
| - delete-ports.yaml | |||
| - delete-merge-values.yaml | |||
There was a problem hiding this comment.
Renamed file mentioned above.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3787 +/- ##
===========================================
- Coverage 54.49% 38.96% -15.53%
===========================================
Files 134 236 +102
Lines 12329 20127 +7798
===========================================
+ Hits 6719 7843 +1124
- Misses 5116 11709 +6593
- Partials 494 575 +81
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -94,12 +98,18 @@ spec: | |||
| - --disable-cert-rotation={{ .Values.controllerManager.disableCertRotation }} | |||
| - --max-serving-threads={{ .Values.maxServingThreads }} | |||
| - --tls-min-version={{ .Values.controllerManager.tlsMinVersion }} | |||
| - --client-ca-name={{ .Values.controllerManager.clientCAName }} | |||
There was a problem hiding this comment.
All of these flags should be set conditionally only when the helm variable is set. We do not want to set new flags to user deployments during upgrades. Additionally, please add the helm variable information in https://github.com/open-policy-agent/gatekeeper/blob/master/cmd/build/helmify/static/README.md as well to make it visible.
|
@ianstanton, hello friend! Can you add some extra missing flag, it is |
@npoxopob Hey there! Sure, I can add that to this PR. |
What this PR does / why we need it:
Add the following flags as helm values and pass down to
controller-managerandauditdeployment templates:--log-level-key--log-level-encoder--cert-dir--api-cache-dir--otlp-endpoint--otlp-metric-interval--stackdriver-only-when-available--stackdriver-metric-interval--disable-enforcementaction-validation--client-ca-name--client-cn-nameWhich issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #3784
Special notes for your reviewer:
I left some of the missing flags in #3784 out as I'm still determining whether they belong as chart values. I also want to be sure the right flags are passed to the appropriate deployments (some are applied to both, others are unique to
controller-manageroraudit), so feedback is welcome there.