feat: gator verify - support multiple expansions for per test case
#3981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ansion file in a case Signed-off-by: grelland <[email protected]> Signed-off-by: Halvdan Hoem Grelland <[email protected]>
Signed-off-by: grelland <[email protected]> Signed-off-by: Halvdan Hoem Grelland <[email protected]>
Signed-off-by: Halvdan Hoem Grelland <[email protected]>
grelland
force-pushed
the
verify-multiple-expansiontemplates
branch
from
e7e27bb to
89df3cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR enchances
gator verifyso that it supports handling multiple expansions for a single test. The existing implementation expects a path to a single file, but does not read multiple YAML documents from said file. This PR remedies that by switching toreader.ReadUnstructuredsunder the hood when creating the test expander.Motivation for wanting this is explained in the linked issue.
Which issue(s) this PR fixes
Fixes #3969