-
Notifications
You must be signed in to change notification settings - Fork 69
External link map for customizable documentation links in frontend repos #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
assign me |
@sarina I've been thinking about how to implement this and had a couple of questions for you.
|
Hey @wgu-taylor-payne - I discussed this with @arbrandes who is definitely more capable of giving answers than I am :) Adolfo could you weigh in, please? |
Actually, after looking into things further, I don't think using the |
@wgu-taylor-payne, this is configuration, after all, and it's why env.config.jsx exists, so I feel the best place for the JSON object to be defined is indeed The behavior of |
Problem statement
Currently docs links are hard-coded to docs.openedx.org; many installations may want to override one or more of these link mappings to their own help sites or internal documentation libraries.
For example, all the links in openedx/frontend-app-authoring#1757
Proposed solution
Create a helper function,
getExternalLinkUrl(default_link)
, that reads from a json blob that specifies replacement links for existing links that individual frontend-app repos have. The json blob should be defined in a global place and is not required for deploys. It is only required if installations wish to override links.The json blob will be in the following format:
that is, the default link will be the key and the desired replacement is the value.
This function will live in
frontend-platform
, withinsrc/config.js
, next toget_config
.Alternatives considered
Support
cc @arbrandes @brian-smith-tcril @tonybusa
Whiteboard:
The text was updated successfully, but these errors were encountered: