Correctly assert against ALREADY_EXISTS index

Signed-off-by: Andre Kurait <[email protected]>

Author: AndreKurait

MetadataMigration/src/test/java/org/opensearch/migrations/EndToEndTest.java

@@ -208,7 +208,8 @@ private void verifyCommandResults(
         var migratedItems = result.getItems();
         assertThat(getNames(getSuccessfulResults(migratedItems.getIndexTemplates())), containsInAnyOrder(testData.indexTemplateName));
         assertThat(getNames(getSuccessfulResults(migratedItems.getComponentTemplates())), equalTo(templateType.equals(TemplateType.IndexAndComponent) ? List.of(testData.compoTemplateName) : List.of()));
-        assertThat(getNames(getSuccessfulResults(migratedItems.getIndexes())), containsInAnyOrder(testData.blogIndexName, testData.movieIndexName, testData.indexThatAlreadyExists));
+        assertThat(getNames(getSuccessfulResults(migratedItems.getIndexes())), containsInAnyOrder(testData.blogIndexName, testData.movieIndexName));
+        assertThat(getNames(getFailedResultsByType(migratedItems.getIndexes(), CreationResult.CreationFailureType.ALREADY_EXISTS)), containsInAnyOrder(testData.indexThatAlreadyExists));
         assertThat(getNames(getSuccessfulResults(migratedItems.getAliases())), containsInAnyOrder(testData.aliasInTemplate, testData.aliasName));
 
     }
@@ -219,6 +220,12 @@ private List<CreationResult> getSuccessfulResults(List<CreationResult> results)
                 .collect(Collectors.toList());
     }
 
+    private List<CreationResult> getFailedResultsByType(List<CreationResult> results, CreationResult.CreationFailureType failureType) {
+        return results.stream()
+                .filter(r -> failureType.equals(r.getFailureType()))
+                .collect(Collectors.toList());
+    }
+
     private List<String> getNames(List<CreationResult> items) {
         return items.stream().map(r -> r.getName()).collect(Collectors.toList());
     }