perf: remove the loop matching Pipeline URLs

By introducing a new field in the FetchedResources struct
to track all remote pipeline URLs, the loop used to match
the correct Pipeline URL based on the Pipeline value
for the current PipelineRun becomes unnecessary. Now,
the value is always the last element in the
FetchedResources.PipelineURLs slice.

This also prevents any nil dereferencing issues.

Author: martindbrv

pkg/resolve/remote.go

@@ -4,7 +4,7 @@ import (
 	"context"
 	"fmt"
 	"net/url"
-	"strings"
+	"path"
 
 	"github.com/openshift-pipelines/pipelines-as-code/pkg/matcher"
 	tektonv1 "github.com/tektoncd/pipeline/pkg/apis/pipeline/v1"
@@ -21,24 +21,14 @@ func alreadyFetchedResource[T NamedItem](resources map[string]T, resourceName st
 	return false
 }
 
-func createTaskURL(eventPipelines map[string]*tektonv1.Pipeline, pipeline *tektonv1.Pipeline, tasks []string) ([]string, error) {
-	var pURL *url.URL
-	var err error
-	for ep := range eventPipelines {
-		// ensure the URL to be parsed matches the
-		// remote pipeline of the current PipelineRun
-		if eventPipelines[ep] != pipeline {
-			continue
-		}
-		pURL, err = url.Parse(ep)
-		if err != nil {
-			return tasks, err
-		}
-		pPath := strings.SplitAfter(pURL.Path, "/")
-		// pop the pipeline target path from the URL
-		pPath = pPath[:len(pPath)-1]
-		pURL.Path = strings.Join(pPath, "")
+func assembleTaskFQDNs(remotePipelineURL string, tasks []string) ([]string, error) {
+	pURL, err := url.Parse(remotePipelineURL)
+	if err != nil {
+		return tasks, err
 	}
+	// pop the pipeline file path from the URL
+	pURL.Path = path.Dir(pURL.Path)
+
 	taskURLS := make([]string, len(tasks))
 	for i, t := range tasks {
 		tURL, err := url.Parse(t)
@@ -68,8 +58,9 @@ func createTaskURL(eventPipelines map[string]*tektonv1.Pipeline, pipeline *tekto
 func resolveRemoteResources(ctx context.Context, rt *matcher.RemoteTasks, types TektonTypes, ropt *Opts) ([]*tektonv1.PipelineRun, error) {
 	// contain Resources fetched for the event
 	fetchedResourcesForEvent := FetchedResources{
-		Tasks:     map[string]*tektonv1.Task{},
-		Pipelines: map[string]*tektonv1.Pipeline{},
+		Tasks:        map[string]*tektonv1.Task{},
+		Pipelines:    map[string]*tektonv1.Pipeline{},
+		PipelineURLs: []string{},
 	}
 	pipelineRuns := []*tektonv1.PipelineRun{}
 	for _, pipelinerun := range types.PipelineRuns {
@@ -110,6 +101,7 @@ func resolveRemoteResources(ctx context.Context, rt *matcher.RemoteTasks, types
 					}
 					// add the pipeline to the Resources fetched for the Event
 					fetchedResourcesForEvent.Pipelines[remotePipeline] = pipeline
+					fetchedResourcesForEvent.PipelineURLs = append(fetchedResourcesForEvent.PipelineURLs, remotePipeline)
 				}
 			}
 		}
@@ -132,8 +124,11 @@ func resolveRemoteResources(ctx context.Context, rt *matcher.RemoteTasks, types
 				if err != nil {
 					return []*tektonv1.PipelineRun{}, fmt.Errorf("error getting remote task from pipeline annotations: %w", err)
 				}
+				// this will always work because the slice cannot be empty (there is a check
+				// for empty strings; even with an empty string it will work), and cannot be nil
+				remotePipelineURL := fetchedResourcesForEvent.PipelineURLs[len(fetchedResourcesForEvent.PipelineURLs)-1]
 				// check for relative task references and assemble FQDNs
-				pipelineTasks, err = createTaskURL(fetchedResourcesForEvent.Pipelines, fetchedResourcesForPipelineRun.Pipeline, pipelineTasks)
+				pipelineTasks, err = assembleTaskFQDNs(remotePipelineURL, pipelineTasks)
 				if err != nil {
 					return []*tektonv1.PipelineRun{}, err
 				}

pkg/resolve/resolve.go

@@ -32,8 +32,9 @@ type TektonTypes struct {
 
 // Contains Fetched Resources for Event, with key equals to annotation value.
 type FetchedResources struct {
-	Tasks     map[string]*tektonv1.Task
-	Pipelines map[string]*tektonv1.Pipeline
+	Tasks        map[string]*tektonv1.Task
+	Pipelines    map[string]*tektonv1.Pipeline
+	PipelineURLs []string
 }
 
 // Contains Fetched Resources for Run, with key equals to resource name from metadata.name field.