Skip to content

If a completed present proof 2.0 webhook is not verified (failed state) see what we can log and/or bring to the UI #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loneil opened this issue Jan 9, 2025 · 1 comment

Comments

@loneil
Copy link
Contributor

loneil commented Jan 9, 2025

In the event a proof is shared but does not pass actually pass the verification (we have this happen with unknown revocation issues with the BC Wallet interoperability lawyer cases before) the webhook comes back but is not verified, triggering our failed status. See some details and screenshot: #703

In that code, if the webhook body DOES contain any relevant details about WHY it failed, we would like to return that to the UI as an expand error section. Kim has mockups.

Other/additonal options:

  • Log out body or specific part on fail
  • Adjust logging so we get an error level log?
  • If webhook contains nothing useful, check if there's any ACA-Py enhancement that could be made to change that. Could check with community and raise an issue.
@esune esune moved this to Assignment Ready in CDT Enterprise Apps Mar 11, 2025
@esune esune moved this from Assignment Ready to Assigned in CDT Enterprise Apps May 2, 2025
@Gavinok Gavinok moved this from Assigned to In Progress in CDT Enterprise Apps May 5, 2025
@Gavinok Gavinok moved this from In Progress to In Review in CDT Enterprise Apps May 12, 2025
@Gavinok Gavinok moved this from In Review to In Progress in CDT Enterprise Apps May 14, 2025
@Gavinok
Copy link
Contributor

Gavinok commented May 15, 2025

openwallet-foundation/acapy#3724 is necessary before this can be implemented

@Gavinok Gavinok removed their assignment May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants