Skip to content

Commit 5176050

Browse files
committed
Fixes by comments
1 parent bc8dbc1 commit 5176050

File tree

4 files changed

+2
-4
lines changed

4 files changed

+2
-4
lines changed

ads/aqua/common/utils.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
from string import Template
2020
from typing import Any, Dict, List, Optional, Union
2121

22+
import fsspec
2223
import oci
2324
from cachetools import TTLCache, cached
2425
from huggingface_hub.constants import HF_HUB_CACHE

ads/aqua/modeldeployment/deployment.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ def create(
218218
model_ids = [model.model_id for model in create_deployment_details.models]
219219
try:
220220
model_config_summary = self.get_multimodel_deployment_config(
221-
model_ids=model_ids
221+
model_ids=model_ids, compartment_id=compartment_id
222222
)
223223
if not model_config_summary.gpu_allocation:
224224
raise AquaValueError(model_config_summary.error_message)

tests/unitary/with_extras/aqua/test_deployment.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -981,8 +981,6 @@ def test_get_deployment(self, mock_get_resource_name):
981981
AquaDeployment.__annotations__.keys()
982982
)
983983
actual_attributes = result.to_dict()
984-
# print(actual_attributes)
985-
print(TestDataset.aqua_deployment_detail)
986984
assert set(actual_attributes) == set(expected_attributes), "Attributes mismatch"
987985
assert actual_attributes == TestDataset.aqua_deployment_detail
988986
assert result.log.name == "log-name"

tests/unitary/with_extras/aqua/test_evaluation.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -630,7 +630,6 @@ def test_validate_model_name(
630630
mock_model, mock_create_aqua_evaluation_details
631631
)
632632
except AquaError as e:
633-
print(str(e))
634633
self.assertEqual(str(e), expected_message)
635634

636635
def test_get_service_model_name(self):

0 commit comments

Comments
 (0)