Skip to content

Ipv6 implementation #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 8, 2025
Merged

Ipv6 implementation #410

merged 9 commits into from
May 8, 2025
+711 −39

Conversation

dranicu
Copy link
Member

@dranicu dranicu commented May 6, 2025

What this PR does / why we need it:
This PR adds support for IPv6 at instance creation.
Adds support for IPv6 for VCN and subnets.
Adds paravirtualized block volumes templates.

Which issue(s) this PR fixes:
Fixes #400

@dranicu dranicu requested review from joekr and MayankKakani May 6, 2025 12:47
@oracle-contributor-agreement Oracle Contributor Agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label May 6, 2025
@dranicu dranicu requested review from vladcristi and removed request for MayankKakani May 6, 2025 12:48
@vladcristi vladcristi force-pushed the ipv6-implementation branch from fe086e6 to 3dd858f Compare May 6, 2025 13:49
@dranicu dranicu force-pushed the ipv6-implementation branch from 3dd858f to b624995 Compare May 6, 2025 14:20
@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels May 6, 2025
joekr
joekr requested changes May 6, 2025
View reviewed changes
@dranicu dranicu removed the request for review from vladcristi May 7, 2025 07:13
joekr
joekr reviewed May 7, 2025
View reviewed changes
@dranicu
Copy link
Member Author

dranicu commented May 8, 2025

Ran the e2e in both main and this branch:

MAIN:

------------------------------

Summarizing 3 Failures:
  [FAIL] Managed Workload cluster creation [It] Managed Cluster - Virtual Node Pool [PRBlocking]
  /home/opc/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/cluster_helpers.go:144
  [FAIL] Workload cluster creation [It] ClusterClass - with 1 control-plane nodes and 1 worker nodes [PRBlocking]
  /home/opc/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/controlplane_helpers.go:153
  [FAIL] Managed Workload cluster creation [It] Managed Cluster - Simple [PRBlocking]
  /home/opc/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/cluster_helpers.go:144

Ran 7 of 28 Specs in 4249.013 seconds
FAIL! -- 4 Passed | 3 Failed | 0 Pending | 21 Skipped

BRANCH

------------------------------

Summarizing 3 Failures:
  [FAIL] Managed Workload cluster creation [It] Managed Cluster - Simple [PRBlocking]
  /home/opc/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/cluster_helpers.go:144
  [FAIL] Workload cluster creation [It] ClusterClass - with 1 control-plane nodes and 1 worker nodes [PRBlocking]
  /home/opc/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/controlplane_helpers.go:153
  [FAIL] Managed Workload cluster creation [It] Managed Cluster - Virtual Node Pool [PRBlocking]
  /home/opc/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/cluster_helpers.go:144

Ran 9 of 30 Specs in 4542.627 seconds
FAIL! -- 6 Passed | 3 Failed | 0 Pending | 21 Skipped

There are 9 PRBlocking tests now.

@joekr
Copy link
Member

joekr commented May 8, 2025 •
edited
Loading

RE: the tests failing.

These are failing right now due to OKE not supporting 1.28.x for new cluster creation. We will have to address this in a new PR in the future.

Created an issue to address this: #411

@joekr joekr merged commit c76772a into main May 8, 2025
1 check passed
@joekr joekr deleted the ipv6-implementation branch May 8, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joekr joekr joekr approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Assigning IPv6 IP Address at Instance Launch
3 participants
@dranicu @joekr @vladcristi