Merge pull request #923 from oracle/feature/PDPDEVTOOL-6106-fix-non-intreactive-action-messages

fix non interactive messages collapsing on spinner

Author: davidecorreu

packages/node-cli/src/commands/file/import/ImportFilesAction.js

@@ -75,7 +75,7 @@ module.exports = class ImportFilesAction extends BaseAction {
 			}
 
 			if (!this._calledFromCompareFiles && !this._calledFromUpdate && this._runInInteractiveMode === false) {
-				this._log.info(NodeTranslationService.getMessage(WARNINGS.OVERRIDE));
+				await this._log.info(NodeTranslationService.getMessage(WARNINGS.OVERRIDE));
 			}
 
 			if (this._calledFromCompareFiles) {

packages/node-cli/src/commands/object/import/ImportObjectsAction.js

@@ -94,7 +94,7 @@ module.exports = class ImportObjectsAction extends BaseAction {
 					scriptIdArray = params[ANSWERS_NAMES.SCRIPT_ID];
 				}
 
-				this._log.info(NodeTranslationService.getMessage(WARNINGS.OVERRIDE));
+				await this._log.info(NodeTranslationService.getMessage(WARNINGS.OVERRIDE));
 			}
 
 			delete params[ANSWERS_NAMES.SCRIPT_ID];

packages/node-cli/src/commands/project/create/CreateProjectAction.js

@@ -162,7 +162,7 @@ module.exports = class CreateProjectAction extends BaseAction {
 	createProject(executionContextCreateProject, params, projectAbsolutePath, projectFolderName, manifestFilePath) {
 		return async (resolve, reject) => {
 			try {
-				this._log.info(NodeTranslationService.getMessage(MESSAGES.CREATING_PROJECT_STRUCTURE));
+				await this._log.info(NodeTranslationService.getMessage(MESSAGES.CREATING_PROJECT_STRUCTURE));
 				if (params[COMMAND_OPTIONS.OVERWRITE]) {
 					this._fileSystemService.emptyFolderRecursive(projectAbsolutePath);
 				}
@@ -187,15 +187,15 @@ module.exports = class CreateProjectAction extends BaseAction {
 				let npmInstallSuccess;
 				let includeUnitTesting = this._getIncludeUnitTestingBoolean(params[COMMAND_OPTIONS.INCLUDE_UNIT_TESTING]);
 				if (includeUnitTesting) {
-					this._log.info(NodeTranslationService.getMessage(MESSAGES.SETUP_TEST_ENV));
+					await this._log.info(NodeTranslationService.getMessage(MESSAGES.SETUP_TEST_ENV));
 					await this._createUnitTestFiles(
 						params[COMMAND_OPTIONS.TYPE],
 						params[COMMAND_OPTIONS.PROJECT_NAME],
 						params[COMMAND_OPTIONS.PROJECT_VERSION],
 						projectAbsolutePath
 					);
 
-					this._log.info(NodeTranslationService.getMessage(MESSAGES.INIT_NPM_DEPENDENCIES));
+					await this._log.info(NodeTranslationService.getMessage(MESSAGES.INIT_NPM_DEPENDENCIES));
 					npmInstallSuccess = await this._runNpmInstall(projectAbsolutePath);
 				} else {
 					await this._createDefaultSuiteCloudConfigFile(projectAbsolutePath);

packages/node-cli/src/commands/project/package/PackageAction.js

@@ -46,7 +46,7 @@ module.exports = class PackageAction extends BaseAction {
 
 		const executionContext = SdkExecutionContext.Builder.forCommand(this._commandMetadata.sdkCommand).integration().addParams(sdkParams).build();
 
-		this._log.warning(NodeTranslationService.getMessage(COMMAND_PACKAGE.LOCAL_VALIDATION_NOT_EXECUTED));
+		await this._log.warning(NodeTranslationService.getMessage(COMMAND_PACKAGE.LOCAL_VALIDATION_NOT_EXECUTED));
 
 		const operationResult = await executeWithSpinner({
 			action: this._sdkExecutor.execute(executionContext),

packages/node-cli/src/core/CommandActionExecutor.js

@@ -112,13 +112,13 @@ module.exports = class CommandActionExecutor {
 		}
 		const inspectAuthzData = inspectAuthzOperationResult.data;
 		if (inspectAuthzData[AUTHORIZATION_PROPERTIES_KEYS.NEEDS_REAUTHORIZATION]) {
-			this._log.info(NodeTranslationService.getMessage(COMMAND_REFRESH_AUTHORIZATION.MESSAGES.CREDENTIALS_NEED_TO_BE_REFRESHED, defaultAuthId));
+			await this._log.info(NodeTranslationService.getMessage(COMMAND_REFRESH_AUTHORIZATION.MESSAGES.CREDENTIALS_NEED_TO_BE_REFRESHED, defaultAuthId));
 			const refreshAuthzOperationResult = await refreshAuthorization(defaultAuthId, this._sdkPath, this._executionEnvironmentContext);
 
 			if (!refreshAuthzOperationResult.isSuccess()) {
 				throw refreshAuthzOperationResult.errorMessages;
 			}
-			this._log.info(NodeTranslationService.getMessage(COMMAND_REFRESH_AUTHORIZATION.MESSAGES.AUTHORIZATION_REFRESH_COMPLETED));
+			await this._log.info(NodeTranslationService.getMessage(COMMAND_REFRESH_AUTHORIZATION.MESSAGES.AUTHORIZATION_REFRESH_COMPLETED));
 		}
 	}
 

packages/node-cli/src/loggers/NodeConsoleLogger.js

@@ -15,25 +15,25 @@ const fontFormatterPromise = loadLoggerFontFormatter();
 class NodeConsoleLogger extends ConsoleLogger {
 
 	info(message) {
-		fontFormatterPromise.then(({ COLORS: { INFO } }) => {
+		return fontFormatterPromise.then(({ COLORS: { INFO } }) => {
 			this._println(message, INFO);
 		});
 	}
 
 	result(message) {
-		fontFormatterPromise.then(({ COLORS: { RESULT } }) => {
+		return fontFormatterPromise.then(({ COLORS: { RESULT } }) => {
 			this._println(message, RESULT);
 		});
 	}
 
 	warning(message) {
-		fontFormatterPromise.then(({ COLORS: { WARNING } }) => {
+		return fontFormatterPromise.then(({ COLORS: { WARNING } }) => {
 			this._println(message, WARNING);
 		});
 	}
 
 	error(message) {
-		fontFormatterPromise.then(({ COLORS: { ERROR } }) => {
+		return fontFormatterPromise.then(({ COLORS: { ERROR } }) => {
 			this._println(message, ERROR);
 		});
 	}