fix: Angular client props nullability #2103
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove angular non-null scalar value handling and instead use DeepNonNullable type to enforce non-null values for http params in generated angular service code.
|
Running the build now! |
|
@jonimake looks like tests are failing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Handle angular http client parameter nullability in a more robust way that doesn't force all schema properties to be non nullable. Adds a new utility type
DeepNonNullablethat is used to wrap all angular client query param props instead of making all scalars non-nullable in angular configuration.Fix #2092 for reference
Todos
Steps to Test or Reproduce
You can either run the tests for the project (there is a new test case for the happy path for angular in
propts.test.ts) or you can generate the sample angular client. The http client query params should be wrapped withDeepNonNullabletype to enforce no nulls can be set there.