API mock handlers not using overrideResponse parameter when response content-type is text/plain

[SampsaKaskela]

What are the steps to reproduce this issue?

I'm generating using following yaml

openapi: '3.0.2'
info:
  title: API
  version: '1.0'
  
paths:
  /{param1}:
    get:
      parameters:
        - in: path
          name: param1
          schema:
            type: string
          required: true
      responses:
        '200':
          description: OK
          content:
            text/plain:
              schema:
                type: string

This is my Orval config

import { defineConfig } from 'orval';

export default defineConfig({
  test: {
    output: {
      workspace: `src/generated/api/test`,
      target: './api.ts',
      mock: true,
    },
    input: {
      target: `./src/generated/yaml/test.yaml`,
    },
  },
});

What happens?

I get following function that doesn't utilize overrideResponse in any way.

export const getGetParam1MockHandler = (overrideResponse?: string | ((info: Parameters<Parameters<typeof http.get>[1]>[0]) => Promise<string> | string)) => {
  return http.get('*/:param1', async (info) => {await delay(1000);
  
    return new HttpResponse(getGetParam1ResponseMock(),
      { status: 200,
        headers: { 'Content-Type': 'text/plain' }
      })
  })
}

What were you expecting to happen?

overrideResponse variable should be used. If I switch to application/json type then I get the following which looks correct.

export const getGetParam1MockHandler = (overrideResponse?: string | ((info: Parameters<Parameters<typeof http.get>[1]>[0]) => Promise<string> | string)) => {
  return http.get('*/:param1', async (info) => {await delay(1000);
  
    return new HttpResponse(JSON.stringify(overrideResponse !== undefined 
            ? (typeof overrideResponse === "function" ? await overrideResponse(info) : overrideResponse) 
            : getGetParam1ResponseMock()),
      { status: 200,
        headers: { 'Content-Type': 'application/json' }
      })
  })
}

Any logs, error output, etc?

Just following, no errors.

🍻 Start orval v7.9.0 - A swagger client generator for typescript
🎉 test - Your OpenAPI spec has been converted into ready to use orval!

What versions are you using?

Orval 7.9.0

[KyleNeedham]

I noticed this logic while reviewing a different fix last week. I’m not sure why the override response isn’t used for text/plain responses—there doesn’t seem to be a clear reason not to apply overrides to all response types.

Maybe @melloware can shed some light on this?

orval/packages/mock/src/msw/index.ts

Lines 141 to 145 in cecfb47

	? isTextPlain
	? `${getResponseMockFunctionName}()`
	: `JSON.stringify(overrideResponse !== undefined
	? (typeof overrideResponse === "function" ? await overrideResponse(${infoParam}) : overrideResponse)
	: ${getResponseMockFunctionName}())`

[melloware]

No idea maybe look at Git Blame and see who made that change and for what ticket and why?

[KyleNeedham]

PR submitted. Based on the history it was originally to avoid calling JSON.stringify on string response types.

[melloware]

Thanks for the fix!