Skip to content

Uploaded images have no protection from being overwritten #374

Open
@DavidGriffith

Description

@DavidGriffith

Suppose I have a product "cat frob" and I upload "frob.jpg" showing a nice cat frob. Later one of my employees creates "dog frob" and uploads "frob.jpg". As is, this will cause oscommerce to happily replace the picture of a dog frob with a picture of a cat frob without warning or complaint. This is a Bad Thing. There needs to be some mechanism to check if that filename exists and complain if there's a collision or do something like insert an identifying string into the filename like this: "frob-12345.jpg" where "12345" is products_id and make sure that doesn't collide either.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions