Skip to content

Commit 0c5fb69

Browse files
committed
Suppress clang-tidy readability-convert-member-functions-to-static.
Some of the transcoder member functions could be made static because they simply return a constant. However, I want to be consistent with the documented transcoder API so they are not static. This change suppresses warnings from clang-tidy when this is happening.
1 parent 15fd8da commit 0c5fb69

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

include/icubaby/icubaby.hpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -762,7 +762,8 @@ template <> class transcoder<char32_t, char8> {
762762
/// \returns True if the input represented well formed UTF-32.
763763
[[nodiscard]] constexpr bool well_formed () const noexcept { return well_formed_; }
764764
/// \returns True if a partial code-point has been passed to operator() and
765-
/// false otherwise.
765+
/// false otherwise.
766+
// NOLINTNEXTLINE(readability-convert-member-functions-to-static)
766767
[[nodiscard]] constexpr bool partial () const noexcept { return false; }
767768

768769
private:
@@ -1005,7 +1006,8 @@ template <> class transcoder<char32_t, char16_t> {
10051006
/// \returns True if the input represented valid UTF-32.
10061007
[[nodiscard]] constexpr bool well_formed () const noexcept { return well_formed_; }
10071008
/// \returns True if a partial code-point has been passed to operator() and
1008-
/// false otherwise.
1009+
/// false otherwise.
1010+
// NOLINTNEXTLINE(readability-convert-member-functions-to-static)
10091011
[[nodiscard]] constexpr bool partial () const noexcept { return false; }
10101012

10111013
private:

0 commit comments

Comments
 (0)