Merge pull request #55 from php-api-clients/trim-ending-_-from-path

WyriHaximus · web-flow · commit 5e716e91f1b0 · 2022-06-04T11:36:34.000+02:00
Trim ending ? from path
diff --git a/src/Generator/Operation.php b/src/Generator/Operation.php
@@ -123,7 +123,7 @@ public static function generate(string $path, string $method, string $namespace,
                                 [
                                     new Node\Expr\Array_(array_map(static fn (string $key): Node\Expr\ArrayItem => new Node\Expr\ArrayItem(new Node\Scalar\String_($key)), array_keys($requestReplaces))),
                                     new Node\Expr\Array_(array_values($requestReplaces)),
-                                    new Node\Scalar\String_($path . '?' . implode('&', $query)),
+                                    new Node\Scalar\String_(rtrim($path . '?' . implode('&', $query), '?')),
                                 ]
                             )),
                         ]

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ public static function generate(string $path, string $method, string $namespace,`
`123`	`123`	`[`
`124`	`124`	`new Node\Expr\Array_(array_map(static fn (string $key): Node\Expr\ArrayItem => new Node\Expr\ArrayItem(new Node\Scalar\String_($key)), array_keys($requestReplaces))),`
`125`	`125`	`new Node\Expr\Array_(array_values($requestReplaces)),`
`126`		`- new Node\Scalar\String_($path . '?' . implode('&', $query)),`
	`126`	`+ new Node\Scalar\String_(rtrim($path . '?' . implode('&', $query), '?')),`
`127`	`127`	`]`
`128`	`128`	`)),`
`129`	`129`	`]`