Try to fix build

Author: LDA

.github/workflows/platform-test.yml

@@ -37,7 +37,7 @@ jobs:
           - php-version: "8.3"
             update-packages: doctrine/orm:^3.0 doctrine/dbal:^4.0 carbonphp/carbon-doctrine-types:^3 gedmo/doctrine-extensions:^3
           - php-version: "8.4"
-            update-packages: doctrine/orm:^3.0 doctrine/dbal:^4.0 carbonphp/carbon-doctrine-types:^3 gedmo/doctrine-extensions:^3
+            update-packages: doctrine/orm:^3.0 doctrine/dbal:^4.0 carbonphp/carbon-doctrine-types:^3 gedmo/doctrine-extensions:^3 symfony/cache:^6.4 symfony/clock:^6.4 symfony/doctrine-bridge:^7.3 symfony/validator:^6.4
 
     steps:
       - name: "Checkout"

composer.json

@@ -36,10 +36,7 @@
 		"phpstan/phpstan-strict-rules": "^2.0",
 		"phpunit/phpunit": "^9.6.20",
 		"ramsey/uuid": "^4.2",
-		"symfony/cache": "^6.4",
-		"symfony/clock": "^6.4",
-		"symfony/doctrine-bridge": "^7.3",
-		"symfony/validator": "^6.4"
+		"symfony/cache": "^5.4"
 	},
 	"config": {
 		"sort-packages": true,

src/Type/Doctrine/Descriptors/Symfony/DatePointType.php

@@ -11,19 +11,23 @@
 class DatePointType implements DoctrineTypeDescriptor
 {
 
+	private const DATE_POINT_TYPE_CLASS = 'Symfony\Bridge\Doctrine\Types\DatePointType';
+	private const DATE_POINT_CLASS = 'Symfony\Component\Clock\DatePoint';
+
 	public function getType(): string
 	{
-		return \Symfony\Bridge\Doctrine\Types\DatePointType::class;
+		/** @var class-string<\Doctrine\DBAL\Types\Type> */
+		return self::DATE_POINT_TYPE_CLASS;
 	}
 
 	public function getWritableToPropertyType(): Type
 	{
-		return new ObjectType(DatePoint::class);
+		return new ObjectType(self::DATE_POINT_CLASS);
 	}
 
 	public function getWritableToDatabaseType(): Type
 	{
-		return new ObjectType(DatePoint::class);
+		return new ObjectType(self::DATE_POINT_CLASS);
 	}
 
 	public function getDatabaseInternalType(): Type

tests/Rules/Doctrine/ORM/EntityColumnRuleTest.php

@@ -26,7 +26,6 @@
 use PHPStan\Type\Doctrine\Descriptors\StringType;
 use PHPStan\Type\Doctrine\Descriptors\Symfony\DatePointType;
 use PHPStan\Type\Doctrine\ObjectMetadataResolver;
-use Symfony\Component\Clock\DatePoint;
 use function array_unshift;
 use function strpos;
 use const PHP_VERSION_ID;
@@ -61,7 +60,7 @@ protected function getRule(): Rule
 		if (!Type::hasType('array')) {
 			Type::addType('array', \Doctrine\DBAL\Types\ArrayType::class);
 		}
-		if (!Type::hasType('date_point')) {
+		if (!Type::hasType('date_point') && class_exists(\Symfony\Bridge\Doctrine\Types\DatePointType::class)) {
 			Type::addType('date_point', \Symfony\Bridge\Doctrine\Types\DatePointType::class);
 		}
 
@@ -172,14 +171,6 @@ public function testRule(?string $objectManagerLoader): void
 				'Property PHPStan\Rules\Doctrine\ORM\MyBrokenEntity::$invalidSimpleArray type mapping mismatch: property can contain array<int> but database expects array<string>.',
 				162,
 			],
-			[
-				'Property PHPStan\Rules\Doctrine\ORM\MyBrokenEntity::$invalidDatePoint type mapping mismatch: database can contain Symfony\Component\Clock\DatePoint but property expects DateTime.',
-				175,
-			],
-			[
-				'Property PHPStan\Rules\Doctrine\ORM\MyBrokenEntity::$invalidDatePoint type mapping mismatch: property can contain DateTime but database expects Symfony\Component\Clock\DatePoint.',
-				175,
-			],
 		];
 
 		$dbalVersion = InstalledVersions::getVersion('doctrine/dbal');
@@ -194,6 +185,34 @@ public function testRule(?string $objectManagerLoader): void
 		$this->analyse([__DIR__ . '/data/MyBrokenEntity.php'], $errors);
 	}
 
+
+	/**
+	 * @dataProvider dataObjectManagerLoader
+	 */
+	public function testRuleSymfony(?string $objectManagerLoader): void
+	{
+		if (!InstalledVersions::isInstalled('symfony/doctrine-bridge')) {
+			$this->markTestSkipped('symfony/doctrine-bridge');
+		}
+
+		$this->allowNullablePropertyForRequiredField = false;
+		$this->objectManagerLoader = $objectManagerLoader;
+
+
+		$errors = [
+			[
+				'Property PHPStan\Rules\Doctrine\ORM\MyBrokenEntity::$invalidDatePoint type mapping mismatch: database can contain Symfony\Component\Clock\DatePoint but property expects DateTime.',
+				175,
+			],
+			[
+				'Property PHPStan\Rules\Doctrine\ORM\MyBrokenEntity::$invalidDatePoint type mapping mismatch: property can contain DateTime but database expects Symfony\Component\Clock\DatePoint.',
+				175,
+			]
+		];
+
+		$this->analyse([__DIR__ . '/data/MySymfonyBrokenEntity.php'], $errors);
+	}
+
 	/**
 	 * @dataProvider dataObjectManagerLoader
 	 */
@@ -251,14 +270,6 @@ public function testRuleWithAllowedNullableProperty(?string $objectManagerLoader
 				'Property PHPStan\Rules\Doctrine\ORM\MyBrokenEntity::$invalidSimpleArray type mapping mismatch: property can contain array<int> but database expects array<string>.',
 				162,
 			],
-			[
-				'Property PHPStan\Rules\Doctrine\ORM\MyBrokenEntity::$invalidDatePoint type mapping mismatch: database can contain Symfony\Component\Clock\DatePoint but property expects DateTime.',
-				175,
-			],
-			[
-				'Property PHPStan\Rules\Doctrine\ORM\MyBrokenEntity::$invalidDatePoint type mapping mismatch: property can contain DateTime but database expects Symfony\Component\Clock\DatePoint.',
-				175,
-			],
 		];
 
 		$dbalVersion = InstalledVersions::getVersion('doctrine/dbal');

tests/Rules/Doctrine/ORM/data/MyBrokenEntity.php

@@ -167,17 +167,4 @@ class MyBrokenEntity extends MyBrokenSuperclass
 	 */
 	private $validSimpleArray;
 
-
-	/**
-	 * @ORM\Column(type="date_point")
-	 * @var \DateTime
-	 */
-	private $invalidDatePoint;
-
-	/**
-	 * @ORM\Column(type="date_point")
-	 * @var \Symfony\Component\Clock\DatePoint
-	 */
-	private $validDatePoint;
-
 }

tests/Rules/Doctrine/ORM/data/MySymfonyBrokenEntity.php

@@ -0,0 +1,24 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Rules\Doctrine\ORM;
+
+use Doctrine\ORM\Mapping as ORM;
+
+/**
+ * @ORM\Entity()
+ */
+class MyBrokenEntity
+{
+	/**
+	 * @ORM\Column(type="date_point")
+	 * @var \DateTime
+	 */
+	private $invalidDatePoint;
+
+	/**
+	 * @ORM\Column(type="date_point")
+	 * @var \Symfony\Component\Clock\DatePoint
+	 */
+	private $validDatePoint;
+
+}