Skip to content

[Feature] Add performance benchmarks to CI/CD pipeline #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
adamamer20 opened this issue Mar 23, 2025 · 2 comments
Open

[Feature] Add performance benchmarks to CI/CD pipeline #129

adamamer20 opened this issue Mar 23, 2025 · 2 comments
Labels
ci Changes to CI configuration files and scripts. good first issue Good for newcomers
Milestone
0.1.0-stable

Comments

@adamamer20
Copy link
Member

adamamer20 commented Mar 23, 2025 •
edited
Loading

🤔 Problem Description

mesa-frames is primarily focused on speed and performance improvements. To maintain this focus, every PR merged into the main branch should be automatically benchmarked through CI/CD using GitHub Actions.
We can create a mesa-frames equivalent of the Mesa benchmarks workflow, ensuring consistent performance tracking on every pull request.

💡 Proposed Solution

  • Add a benchmarks.yml GitHub Actions workflow
  • Run mesa-frames examples as benchmark tests on PRs targeting the main branch
  • Ensure benchmark results are visible and ready for review during the PR process

🔄 Alternatives Considered

No response

➕ Additional Context

No response
@adamamer20 adamamer20 added ci Changes to CI configuration files and scripts. good first issue Good for newcomers labels Mar 23, 2025
@adamamer20 adamamer20 added this to the 0.1.0-stable milestone Mar 23, 2025
suryanshgargbpgc added a commit to suryanshgargbpgc/mesa-frames that referenced this issue Mar 23, 2025
@suryanshgargbpgc
solves issue projectmesa#129
3e06602 
1. Adds Github actions workflow similar to https://github.com/projectmesa/mesa/blob/main/.github/workflows/benchmarks.yml
2. Documentation added (benchmark.md)
3.updated mkdocs.yml to include new documentation in the navigation
@suryanshgargbpgc
Copy link

suryanshgargbpgc commented Mar 23, 2025 •
edited
Loading

Hi @adamamer20 I am getting this error while I commit the PR, so as far as I could understand it is something related to mesa 3.0 which is not yet updated in mesa frames, so I think I must solve the issue #128 before this ?
Image

@adamamer20
Copy link
Member Author

Correct, either update the mesa example to 3.0 or pin the mesa version to 2.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci Changes to CI configuration files and scripts. good first issue Good for newcomers
Projects
None yet
Milestone
0.1.0-stable
Development

No branches or pull requests
2 participants
@suryanshgargbpgc @adamamer20