Merge pull request #83 from cpick/fatal-collection-error

SuperQ · web-flow · commit f9cd352a796a · 2020-05-13T15:27:30.000+02:00
Treat failure to collect metric as fatal
diff --git a/collectors/monitoring_collector.go b/collectors/monitoring_collector.go
@@ -187,7 +187,7 @@ func (c *MonitoringCollector) Collect(ch chan<- prometheus.Metric) {
 	if err := c.reportMonitoringMetrics(ch); err != nil {
 		errorMetric = float64(1)
 		c.scrapeErrorsTotalMetric.Inc()
-		log.Errorf("Error while getting Google Stackdriver Monitoring metrics: %s", err)
+		log.Fatalf("Error while getting Google Stackdriver Monitoring metrics: %s", err)
 	}
 	c.scrapeErrorsTotalMetric.Collect(ch)
 

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ func (c *MonitoringCollector) Collect(ch chan<- prometheus.Metric) {`
`187`	`187`	`if err := c.reportMonitoringMetrics(ch); err != nil {`
`188`	`188`	`errorMetric = float64(1)`
`189`	`189`	`c.scrapeErrorsTotalMetric.Inc()`
`190`		`- log.Errorf("Error while getting Google Stackdriver Monitoring metrics: %s", err)`
	`190`	`+ log.Fatalf("Error while getting Google Stackdriver Monitoring metrics: %s", err)`
`191`	`191`	`}`
`192`	`192`	`c.scrapeErrorsTotalMetric.Collect(ch)`
`193`	`193`