Skip to content

Allow passing pre-allocated buffer to proxy_get_buffer_bytes #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leonm1 opened this issue May 2, 2025 · 1 comment
Open

Allow passing pre-allocated buffer to proxy_get_buffer_bytes #83

leonm1 opened this issue May 2, 2025 · 1 comment

Comments

@leonm1
Copy link
Contributor

leonm1 commented May 2, 2025

We've seen a common pattern emerging where plugin authors will call proxy_get_buffer_bytes with a specific length in mind, do something with the buffer, then clear all buffers when returning from the callback.

By allowing authors to pass a pre-allocated buffer, we'd permit plugin authors to stack-allocate this memory, which is cheaper to manage than heap allocating. In the case of garbage collected languages, such as Go, this would allow us to completely bypass the garbage collector.

Furthermore, this approach can provide plugin authors significantly more control over the memory usage when using garbage collected languages, since the contents of the buffer are guaranteed to be freed at the end of the callback (and individual callbacks in a thread local vm are guaranteed non-concurrent).

@leonm1
Copy link
Contributor Author

leonm1 commented May 2, 2025

FWIW this is currently under-specified in the spec (and is a non-breaking change), so this may be permissible to change without a major version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant