Skip to content

Commit 1e8d23c

Browse files
committed
Use early return suggestion from @DragonMoffon
1 parent 36d5f2b commit 1e8d23c

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

arcade/sprite/base.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -177,15 +177,17 @@ def width(self) -> float:
177177
@width.setter
178178
def width(self, new_value: float):
179179
size = self._size
180-
if new_value != size[0]:
181-
new_scale = Vec2(new_value / self._texture.width, self._scale[1])
182-
self._scale = new_scale
183-
self._hit_box.scale = new_scale
184-
self._size = Vec2(new_value, size[1])
180+
if new_value == size[0]:
181+
return
185182

186-
self.update_spatial_hash()
187-
for sprite_list in self.sprite_lists:
188-
sprite_list._update_width(self)
183+
new_scale = Vec2(new_value / self._texture.width, self._scale[1])
184+
self._scale = new_scale
185+
self._hit_box.scale = new_scale
186+
self._size = Vec2(new_value, size[1])
187+
188+
self.update_spatial_hash()
189+
for sprite_list in self.sprite_lists:
190+
sprite_list._update_width(self)
189191

190192
@property
191193
def height(self) -> float:

0 commit comments

Comments
 (0)