Skip to content

WIP: feat: support RestResponse generation for reactive clients #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

pickbreaker
Copy link

Closes #1033

@pickbreaker pickbreaker requested a review from a team as a code owner March 6, 2025 11:08
@pickbreaker pickbreaker marked this pull request as draft March 6, 2025 11:08
@pickbreaker
Copy link
Author

I am currently a little stuck on how to correctly implement the tests such that the RestResponse APIs are only generated if the maven profile ist reasteasy-reactive, because otherwise they throw a type error because of the missing resteasy-reactive dependency.

@hbelmiro
Copy link
Contributor

hbelmiro commented Mar 8, 2025

I am currently a little stuck on how to correctly implement the tests such that the RestResponse APIs are only generated if the maven profile ist reasteasy-reactive, because otherwise they throw a type error because of the missing resteasy-reactive dependency.

@pickbreaker I'm not following.
Are you trying to return org.jboss.resteasy.reactive.RestResponse when using the classic profile?

@pickbreaker
Copy link
Author

No. In the integration tests the same code is generated no matter the profile. But this config option should only be supported on reactive clients like with the mutiny option. Now when the reactive code is generated when running the tests in classic profile the compilation of course fails. I tried only generating the api for when the profile is reactive, but could not find a clean way to do so.

Copy link
Contributor

@ricardozanini @hbelmiro This is being labeled as Stale.

@github-actions github-actions bot added the Stale label May 10, 2025
Copy link
Contributor

@ricardozanini @hbelmiro This is being closed due to inactivity.

@github-actions github-actions bot closed this May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support org.jboss.resteasy.reactive.RestResponse<>
2 participants