Merge pull request #3 from randlabs/staticcheck

Applied Static-check tool

Author: mxmauro

httpclient/httpclient.go

@@ -80,9 +80,7 @@ func (c *HttpClient) AddSource(baseURL string, header http.Header, opts loadbala
 	}
 
 	// Remove trailing slash
-	if strings.HasSuffix(baseURL, "/") {
-		baseURL = baseURL[0 : len(baseURL)-1]
-	}
+	baseURL = strings.TrimSuffix(baseURL, "/")
 
 	// Add source to list
 	src := newSource(len(c.sources) + 1, baseURL, header, opts.IsBackup)

httpclient/internal.go

@@ -8,7 +8,7 @@ import (
 
 // -----------------------------------------------------------------------------
 
-var serverDownErr = errors.New("server down")
+var errServerDown = errors.New("server down")
 
 // -----------------------------------------------------------------------------
 
@@ -26,7 +26,7 @@ func (c *HttpClient) balancerEventHandler(eventType int, srv *balancer.Server) {
 	case balancer.ServerDownEvent:
 		src.setOnlineStatus(false)
 		if c.eventHandler != nil {
-			c.eventHandler(ServerDownEvent, src.ID(), serverDownErr)
+			c.eventHandler(ServerDownEvent, src.ID(), errServerDown)
 		}
 	}
 }

loadbalancer.go

@@ -2,7 +2,6 @@ package loadbalancer
 
 import (
 	"errors"
-	"io"
 	"sync"
 	"time"
 )
@@ -25,15 +24,14 @@ type EventHandler func(eventType int, server *Server)
 // -----------------------------------------------------------------------------
 
 const (
-	ServerUpEvent int = iota + 1
+	ServerUpEvent   int = iota + 1
 	ServerDownEvent
 )
 
 // -----------------------------------------------------------------------------
 
 // Create creates a new load balancer manager
 func Create() *LoadBalancer {
-	io.ErrClosedPipe = nil
 	lb := LoadBalancer{
 		mtx: sync.Mutex{},
 		primaryGroup: ServerGroup{