-
-
Notifications
You must be signed in to change notification settings - Fork 180
feat: blurhash of image files #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
How would you like to see this implemented? There are crates that implement the blurhash algorithm, which can just be used as a crate to add a field to an image. How would this need to be implemented? |
Just need an extra field on the FileHash object that includes the hash, that can be included&served to clients |
I would recommend using thumbhash as an alternative to blurhash as blurhash does not have transparency support. |
It seems like the project isn't maintained very actively, so I don't know if it is smart to use. |
Could it be smarter to include a blurhash field to the |
Discord and presumably many other companies are activly using this implementation (see https://github.com/discord/lilliput/blob/master/thumbhash.cpp). The same about active maintaining could be said about blurhash too. Having to use blurhash also means extra information such as width and height will have to be stored instead of just using a single string. It is an implementation that really does not need much maintainence once implemented as what is going to change?
|
Wasn't aware of that. Width and height are already stored in revolt, though (see file_hashes). I would say that the final choice is up to insert. |
No description provided.
The text was updated successfully, but these errors were encountered: