Skip to content

Commit ec9a20e

Browse files
authored
maint: update dev.txt and gcs protocol names (#242)
* update to gcs naming * update to latest version of quartodoc
1 parent 2b7bebb commit ec9a20e

File tree

3 files changed

+140
-117
lines changed

3 files changed

+140
-117
lines changed

pins/constructors.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,11 @@ def board_deparse(board: BaseBoard):
5858
return f"board_connect(server_url={repr(url)}{allow_pickle})"
5959
elif prot in ["file", ("file", "local")]:
6060
return f"board_folder({repr(board.board)}{allow_pickle})"
61-
elif prot in [["s3", "s3a"], ("s3", "s3a")]:
61+
elif set(prot) == {"s3", "s3a"}:
6262
return f"board_s3({repr(board.board)}{allow_pickle})"
6363
elif prot == "abfs":
6464
return f"board_azure({repr(board.board)}{allow_pickle})"
65-
elif prot == ("gcs", "gs"):
65+
elif set(prot) == {"gcs", "gs"} or prot == "gs":
6666
return f"board_gcs({repr(board.board)}{allow_pickle})"
6767
elif prot == "http":
6868
return f"board_url({repr(board.board)}, {board.pin_paths}{allow_pickle})"

pins/tests/test_constructors.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@ def construct_from_board(board):
4747
)
4848
elif fs_name == "abfs":
4949
board = c.board_azure(board.board)
50+
elif fs_name == "gs":
51+
board = c.board_gcs(board.board)
5052
else:
5153
board = getattr(c, f"board_{fs_name}")(board.board)
5254

0 commit comments

Comments
 (0)