Skip to content

Commit 73ab5ba

Browse files
rtfpessoartfpessoa
authored
Merge pull request #389 from mohd-akram/remove-redundant-classes
Remove redundant HTML classes
2 parents be5d5ee + ac9e2ce commit 73ab5ba

File tree

7 files changed

+108
-108
lines changed

7 files changed

+108
-108
lines changed

‎src/__tests__/diff2html-tests.ts

Lines changed: 66 additions & 66 deletions
Large diffs are not rendered by default.

‎src/__tests__/hogan-cache-tests.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ describe('HoganJsUtils', () => {
1212
expect(result).toMatchInlineSnapshot(`
1313
"<tr>
1414
<td class=\\"d2h-info\\">
15-
<div class=\\"d2h-code-line d2h-info\\">
15+
<div class=\\"d2h-code-line\\">
1616
File without changes
1717
</div>
1818
</td>

‎src/__tests__/line-by-line-tests.ts

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ describe('LineByLineRenderer', () => {
1212
expect(fileHtml).toMatchInlineSnapshot(`
1313
"<tr>
1414
<td class=\\"d2h-info\\">
15-
<div class=\\"d2h-code-line d2h-info\\">
15+
<div class=\\"d2h-code-line\\">
1616
File without changes
1717
</div>
1818
</td>
@@ -39,7 +39,7 @@ describe('LineByLineRenderer', () => {
3939
<div class=\\"line-num2\\">30</div>
4040
</td>
4141
<td class=\\"d2h-ins\\">
42-
<div class=\\"d2h-code-line d2h-ins\\">
42+
<div class=\\"d2h-code-line\\">
4343
<span class=\\"d2h-code-line-prefix\\">+</span>
4444
<span class=\\"d2h-code-line-ctn\\">test</span>
4545
</div>
@@ -65,7 +65,7 @@ describe('LineByLineRenderer', () => {
6565
<div class=\\"line-num2\\"></div>
6666
</td>
6767
<td class=\\"d2h-del\\">
68-
<div class=\\"d2h-code-line d2h-del\\">
68+
<div class=\\"d2h-code-line\\">
6969
<span class=\\"d2h-code-line-prefix\\">-</span>
7070
<span class=\\"d2h-code-line-ctn\\">test</span>
7171
</div>
@@ -91,7 +91,7 @@ describe('LineByLineRenderer', () => {
9191
<div class=\\"line-num2\\">30</div>
9292
</td>
9393
<td class=\\"d2h-ins\\">
94-
<div class=\\"d2h-code-line d2h-ins\\">
94+
<div class=\\"d2h-code-line\\">
9595
<span class=\\"d2h-code-line-prefix\\">+</span>
9696
<span class=\\"d2h-code-line-ctn\\"> test</span>
9797
</div>
@@ -117,7 +117,7 @@ describe('LineByLineRenderer', () => {
117117
<div class=\\"line-num2\\">30</div>
118118
</td>
119119
<td class=\\"d2h-ins\\">
120-
<div class=\\"d2h-code-line d2h-ins\\">
120+
<div class=\\"d2h-code-line\\">
121121
<span class=\\"d2h-code-line-prefix\\">+</span>
122122
<span class=\\"d2h-code-line-ctn\\"> test</span>
123123
</div>
@@ -143,7 +143,7 @@ describe('LineByLineRenderer', () => {
143143
<div class=\\"line-num2\\">30</div>
144144
</td>
145145
<td class=\\"d2h-ins\\">
146-
<div class=\\"d2h-code-line d2h-ins\\">
146+
<div class=\\"d2h-code-line\\">
147147
<span class=\\"d2h-code-line-prefix\\">+</span>
148148
<span class=\\"d2h-code-line-ctn\\"> test</span>
149149
</div>
@@ -419,15 +419,15 @@ describe('LineByLineRenderer', () => {
419419
<tr>
420420
<td class=\\"d2h-code-linenumber d2h-info\\"></td>
421421
<td class=\\"d2h-info\\">
422-
<div class=\\"d2h-code-line d2h-info\\">@@ -1 +1 @@</div>
422+
<div class=\\"d2h-code-line\\">@@ -1 +1 @@</div>
423423
</td>
424424
</tr><tr>
425425
<td class=\\"d2h-code-linenumber d2h-del d2h-change\\">
426426
<div class=\\"line-num1\\">1</div>
427427
<div class=\\"line-num2\\"></div>
428428
</td>
429429
<td class=\\"d2h-del d2h-change\\">
430-
<div class=\\"d2h-code-line d2h-del d2h-change\\">
430+
<div class=\\"d2h-code-line\\">
431431
<span class=\\"d2h-code-line-prefix\\">-</span>
432432
<span class=\\"d2h-code-line-ctn\\"><del>test</del></span>
433433
</div>
@@ -438,7 +438,7 @@ describe('LineByLineRenderer', () => {
438438
<div class=\\"line-num2\\">1</div>
439439
</td>
440440
<td class=\\"d2h-ins d2h-change\\">
441-
<div class=\\"d2h-code-line d2h-ins d2h-change\\">
441+
<div class=\\"d2h-code-line\\">
442442
<span class=\\"d2h-code-line-prefix\\">+</span>
443443
<span class=\\"d2h-code-line-ctn\\"><ins>test1r</ins></span>
444444
</div>
@@ -492,7 +492,7 @@ describe('LineByLineRenderer', () => {
492492
<tbody class=\\"d2h-diff-tbody\\">
493493
<tr>
494494
<td class=\\"d2h-info\\">
495-
<div class=\\"d2h-code-line d2h-info\\">
495+
<div class=\\"d2h-code-line\\">
496496
File without changes
497497
</div>
498498
</td>
@@ -553,7 +553,7 @@ describe('LineByLineRenderer', () => {
553553
<tr>
554554
<td class=\\"d2h-code-linenumber d2h-info\\"></td>
555555
<td class=\\"d2h-info\\">
556-
<div class=\\"d2h-code-line d2h-info\\"><a href=\\"http://example.com\\">Custom link to render</a></div>
556+
<div class=\\"d2h-code-line\\"><a href=\\"http://example.com\\">Custom link to render</a></div>
557557
</td>
558558
</tr>
559559
</tbody>
@@ -622,15 +622,15 @@ describe('LineByLineRenderer', () => {
622622
"<tr>
623623
<td class=\\"d2h-code-linenumber d2h-info\\"></td>
624624
<td class=\\"d2h-info\\">
625-
<div class=\\"d2h-code-line d2h-info\\">@@ -1 +1 @@</div>
625+
<div class=\\"d2h-code-line\\">@@ -1 +1 @@</div>
626626
</td>
627627
</tr><tr>
628628
<td class=\\"d2h-code-linenumber d2h-cntx\\">
629629
<div class=\\"line-num1\\">1</div>
630630
<div class=\\"line-num2\\">1</div>
631631
</td>
632632
<td class=\\"d2h-cntx\\">
633-
<div class=\\"d2h-code-line d2h-cntx\\">
633+
<div class=\\"d2h-code-line\\">
634634
<span class=\\"d2h-code-line-prefix\\">&nbsp;</span>
635635
<span class=\\"d2h-code-line-ctn\\">one context line</span>
636636
</div>
@@ -641,7 +641,7 @@ describe('LineByLineRenderer', () => {
641641
<div class=\\"line-num2\\"></div>
642642
</td>
643643
<td class=\\"d2h-del d2h-change\\">
644-
<div class=\\"d2h-code-line d2h-del d2h-change\\">
644+
<div class=\\"d2h-code-line\\">
645645
<span class=\\"d2h-code-line-prefix\\">-</span>
646646
<span class=\\"d2h-code-line-ctn\\"><del>test</del></span>
647647
</div>
@@ -652,7 +652,7 @@ describe('LineByLineRenderer', () => {
652652
<div class=\\"line-num2\\">2</div>
653653
</td>
654654
<td class=\\"d2h-ins d2h-change\\">
655-
<div class=\\"d2h-code-line d2h-ins d2h-change\\">
655+
<div class=\\"d2h-code-line\\">
656656
<span class=\\"d2h-code-line-prefix\\">+</span>
657657
<span class=\\"d2h-code-line-ctn\\"><ins>test1r</ins></span>
658658
</div>
@@ -663,7 +663,7 @@ describe('LineByLineRenderer', () => {
663663
<div class=\\"line-num2\\">3</div>
664664
</td>
665665
<td class=\\"d2h-ins\\">
666-
<div class=\\"d2h-code-line d2h-ins\\">
666+
<div class=\\"d2h-code-line\\">
667667
<span class=\\"d2h-code-line-prefix\\">+</span>
668668
<span class=\\"d2h-code-line-ctn\\">test2r</span>
669669
</div>

‎src/__tests__/side-by-side-printer-tests.ts

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ describe('SideBySideRenderer', () => {
1313
Object {
1414
"left": "<tr>
1515
<td class=\\"d2h-info\\">
16-
<div class=\\"d2h-code-side-line d2h-info\\">
16+
<div class=\\"d2h-code-side-line\\">
1717
File without changes
1818
</div>
1919
</td>
@@ -82,14 +82,14 @@ describe('SideBySideRenderer', () => {
8282
"left": "<tr>
8383
<td class=\\"d2h-code-side-linenumber d2h-info\\"></td>
8484
<td class=\\"d2h-info\\">
85-
<div class=\\"d2h-code-side-line d2h-info\\">@@ -19,7 +19,7 @@</div>
85+
<div class=\\"d2h-code-side-line\\">@@ -19,7 +19,7 @@</div>
8686
</td>
8787
</tr><tr>
8888
<td class=\\"d2h-code-side-linenumber d2h-cntx\\">
8989
19
9090
</td>
9191
<td class=\\"d2h-cntx\\">
92-
<div class=\\"d2h-code-side-line d2h-cntx\\">
92+
<div class=\\"d2h-code-side-line\\">
9393
<span class=\\"d2h-code-line-prefix\\">&nbsp;</span>
9494
<span class=\\"d2h-code-line-ctn\\">context</span>
9595
</div>
@@ -99,7 +99,7 @@ describe('SideBySideRenderer', () => {
9999
20
100100
</td>
101101
<td class=\\"d2h-del d2h-change\\">
102-
<div class=\\"d2h-code-side-line d2h-del d2h-change\\">
102+
<div class=\\"d2h-code-side-line\\">
103103
<span class=\\"d2h-code-line-prefix\\">-</span>
104104
<span class=\\"d2h-code-line-ctn\\"><del>removed</del></span>
105105
</div>
@@ -109,7 +109,7 @@ describe('SideBySideRenderer', () => {
109109
110110
</td>
111111
<td class=\\"d2h-cntx d2h-emptyplaceholder\\">
112-
<div class=\\"d2h-code-side-line d2h-code-side-emptyplaceholder d2h-cntx d2h-emptyplaceholder\\">
112+
<div class=\\"d2h-code-side-line d2h-code-side-emptyplaceholder\\">
113113
<span class=\\"d2h-code-line-prefix\\">&nbsp;</span>
114114
<span class=\\"d2h-code-line-ctn\\"><br></span>
115115
</div>
@@ -118,14 +118,14 @@ describe('SideBySideRenderer', () => {
118118
"right": "<tr>
119119
<td class=\\"d2h-code-side-linenumber d2h-info\\"></td>
120120
<td class=\\"d2h-info\\">
121-
<div class=\\"d2h-code-side-line d2h-info\\"></div>
121+
<div class=\\"d2h-code-side-line\\"></div>
122122
</td>
123123
</tr><tr>
124124
<td class=\\"d2h-code-side-linenumber d2h-cntx\\">
125125
19
126126
</td>
127127
<td class=\\"d2h-cntx\\">
128-
<div class=\\"d2h-code-side-line d2h-cntx\\">
128+
<div class=\\"d2h-code-side-line\\">
129129
<span class=\\"d2h-code-line-prefix\\">&nbsp;</span>
130130
<span class=\\"d2h-code-line-ctn\\">context</span>
131131
</div>
@@ -135,7 +135,7 @@ describe('SideBySideRenderer', () => {
135135
20
136136
</td>
137137
<td class=\\"d2h-ins d2h-change\\">
138-
<div class=\\"d2h-code-side-line d2h-ins d2h-change\\">
138+
<div class=\\"d2h-code-side-line\\">
139139
<span class=\\"d2h-code-line-prefix\\">+</span>
140140
<span class=\\"d2h-code-line-ctn\\"><ins>added</ins></span>
141141
</div>
@@ -145,7 +145,7 @@ describe('SideBySideRenderer', () => {
145145
21
146146
</td>
147147
<td class=\\"d2h-ins\\">
148-
<div class=\\"d2h-code-side-line d2h-ins\\">
148+
<div class=\\"d2h-code-side-line\\">
149149
<span class=\\"d2h-code-line-prefix\\">+</span>
150150
<span class=\\"d2h-code-line-ctn\\">another added</span>
151151
</div>
@@ -174,7 +174,7 @@ describe('SideBySideRenderer', () => {
174174
175175
</td>
176176
<td class=\\"d2h-cntx d2h-emptyplaceholder\\">
177-
<div class=\\"d2h-code-side-line d2h-code-side-emptyplaceholder d2h-cntx d2h-emptyplaceholder\\">
177+
<div class=\\"d2h-code-side-line d2h-code-side-emptyplaceholder\\">
178178
<span class=\\"d2h-code-line-prefix\\">&nbsp;</span>
179179
<span class=\\"d2h-code-line-ctn\\"><br></span>
180180
</div>
@@ -185,7 +185,7 @@ describe('SideBySideRenderer', () => {
185185
30
186186
</td>
187187
<td class=\\"d2h-ins\\">
188-
<div class=\\"d2h-code-side-line d2h-ins\\">
188+
<div class=\\"d2h-code-side-line\\">
189189
<span class=\\"d2h-code-line-prefix\\">+</span>
190190
<span class=\\"d2h-code-line-ctn\\">test</span>
191191
</div>
@@ -214,7 +214,7 @@ describe('SideBySideRenderer', () => {
214214
30
215215
</td>
216216
<td class=\\"d2h-del\\">
217-
<div class=\\"d2h-code-side-line d2h-del\\">
217+
<div class=\\"d2h-code-side-line\\">
218218
<span class=\\"d2h-code-line-prefix\\">-</span>
219219
<span class=\\"d2h-code-line-ctn\\">test</span>
220220
</div>
@@ -225,7 +225,7 @@ describe('SideBySideRenderer', () => {
225225
226226
</td>
227227
<td class=\\"d2h-cntx d2h-emptyplaceholder\\">
228-
<div class=\\"d2h-code-side-line d2h-code-side-emptyplaceholder d2h-cntx d2h-emptyplaceholder\\">
228+
<div class=\\"d2h-code-side-line d2h-code-side-emptyplaceholder\\">
229229
<span class=\\"d2h-code-line-prefix\\">&nbsp;</span>
230230
<span class=\\"d2h-code-line-ctn\\"><br></span>
231231
</div>
@@ -299,14 +299,14 @@ describe('SideBySideRenderer', () => {
299299
<tr>
300300
<td class=\\"d2h-code-side-linenumber d2h-info\\"></td>
301301
<td class=\\"d2h-info\\">
302-
<div class=\\"d2h-code-side-line d2h-info\\">@@ -1 +1 @@</div>
302+
<div class=\\"d2h-code-side-line\\">@@ -1 +1 @@</div>
303303
</td>
304304
</tr><tr>
305305
<td class=\\"d2h-code-side-linenumber d2h-del d2h-change\\">
306306
1
307307
</td>
308308
<td class=\\"d2h-del d2h-change\\">
309-
<div class=\\"d2h-code-side-line d2h-del d2h-change\\">
309+
<div class=\\"d2h-code-side-line\\">
310310
<span class=\\"d2h-code-line-prefix\\">-</span>
311311
<span class=\\"d2h-code-line-ctn\\"><del>test</del></span>
312312
</div>
@@ -323,14 +323,14 @@ describe('SideBySideRenderer', () => {
323323
<tr>
324324
<td class=\\"d2h-code-side-linenumber d2h-info\\"></td>
325325
<td class=\\"d2h-info\\">
326-
<div class=\\"d2h-code-side-line d2h-info\\"></div>
326+
<div class=\\"d2h-code-side-line\\"></div>
327327
</td>
328328
</tr><tr>
329329
<td class=\\"d2h-code-side-linenumber d2h-ins d2h-change\\">
330330
1
331331
</td>
332332
<td class=\\"d2h-ins d2h-change\\">
333-
<div class=\\"d2h-code-side-line d2h-ins d2h-change\\">
333+
<div class=\\"d2h-code-side-line\\">
334334
<span class=\\"d2h-code-line-prefix\\">+</span>
335335
<span class=\\"d2h-code-line-ctn\\"><ins>test1r</ins></span>
336336
</div>
@@ -383,7 +383,7 @@ describe('SideBySideRenderer', () => {
383383
<tbody class=\\"d2h-diff-tbody\\">
384384
<tr>
385385
<td class=\\"d2h-info\\">
386-
<div class=\\"d2h-code-side-line d2h-info\\">
386+
<div class=\\"d2h-code-side-line\\">
387387
File without changes
388388
</div>
389389
</td>
@@ -455,7 +455,7 @@ describe('SideBySideRenderer', () => {
455455
<tr>
456456
<td class=\\"d2h-code-side-linenumber d2h-info\\"></td>
457457
<td class=\\"d2h-info\\">
458-
<div class=\\"d2h-code-side-line d2h-info\\"><a href=\\"http://example.com\\">Custom link to render</a></div>
458+
<div class=\\"d2h-code-side-line\\"><a href=\\"http://example.com\\">Custom link to render</a></div>
459459
</td>
460460
</tr>
461461
</tbody>
@@ -469,7 +469,7 @@ describe('SideBySideRenderer', () => {
469469
<tr>
470470
<td class=\\"d2h-code-side-linenumber d2h-info\\"></td>
471471
<td class=\\"d2h-info\\">
472-
<div class=\\"d2h-code-side-line d2h-info\\"></div>
472+
<div class=\\"d2h-code-side-line\\"></div>
473473
</td>
474474
</tr>
475475
</tbody>
@@ -514,7 +514,7 @@ describe('SideBySideRenderer', () => {
514514
1
515515
</td>
516516
<td class=\\"d2h-del d2h-change\\">
517-
<div class=\\"d2h-code-side-line d2h-del d2h-change\\">
517+
<div class=\\"d2h-code-side-line\\">
518518
<span class=\\"d2h-code-line-prefix\\">-</span>
519519
<span class=\\"d2h-code-line-ctn\\"><del>test</del></span>
520520
</div>
@@ -525,7 +525,7 @@ describe('SideBySideRenderer', () => {
525525
1
526526
</td>
527527
<td class=\\"d2h-ins d2h-change\\">
528-
<div class=\\"d2h-code-side-line d2h-ins d2h-change\\">
528+
<div class=\\"d2h-code-side-line\\">
529529
<span class=\\"d2h-code-line-prefix\\">+</span>
530530
<span class=\\"d2h-code-line-ctn\\"><ins>test1r</ins></span>
531531
</div>

‎src/templates/generic-block-header.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<tr>
22
<td class="{{lineClass}} {{CSSLineClass.INFO}}"></td>
33
<td class="{{CSSLineClass.INFO}}">
4-
<div class="{{contentClass}} {{CSSLineClass.INFO}}">{{{blockHeader}}}</div>
4+
<div class="{{contentClass}}">{{{blockHeader}}}</div>
55
</td>
66
</tr>

‎src/templates/generic-empty-diff.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<tr>
22
<td class="{{CSSLineClass.INFO}}">
3-
<div class="{{contentClass}} {{CSSLineClass.INFO}}">
3+
<div class="{{contentClass}}">
44
File without changes
55
</div>
66
</td>

‎src/templates/generic-line.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
{{{lineNumber}}}
44
</td>
55
<td class="{{type}}">
6-
<div class="{{contentClass}} {{type}}">
6+
<div class="{{contentClass}}">
77
{{#prefix}}
88
<span class="d2h-code-line-prefix">{{{prefix}}}</span>
99
{{/prefix}}

0 commit comments

Comments
 (0)