Skip to content

Connections remain in CLOSE_WAIT status due to lack of proper disposal #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashishbinu opened this issue Dec 31, 2024 · 0 comments
Open

Comments

@ashishbinu
Copy link

The network connections in the Connection and Connector classes are not being properly disposed, leading to connections lingering in the CLOSE_WAIT state.

To fix this, the classes should implement IDisposable to ensure proper cleanup of resources.

I propose updating the client.Replicate function to use the connection like this:

using var connector = new Connector(_options);
var (connection, databaseProvider) = await connector.ConnectAsync(cancellationToken);

If this is okay, I can submit a PR for these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant