You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 8, 2021. It is now read-only.
Similar to #59 I was just bitten by the fact that you could construct a MetaGraph from a LightGraphs.SimpleDiGraph, dropping the directedness. I was wondering whether this kind of implicit conversion to an undirected graph is ever desirable. I feel like it may be preferable to require explicit conversion via convert instead. Or, perhaps, issue a warning upon construction of an undirected graph from a directed one?
The text was updated successfully, but these errors were encountered:
We allow construction of (undirected) SimpleGraphs from SimpleDiGraphs, though I can see how this might be confusing. I'm open to dropping the constructor, but this means you'd have to go SimpleDiGraph -> SimpleGraph -> MetaGraph if you wanted an undirected MetaGraph from a SimpleDiGraph.
Similar to #59 I was just bitten by the fact that you could construct a
MetaGraph
from aLightGraphs.SimpleDiGraph
, dropping the directedness. I was wondering whether this kind of implicit conversion to an undirected graph is ever desirable. I feel like it may be preferable to require explicit conversion viaconvert
instead. Or, perhaps, issue a warning upon construction of an undirected graph from a directed one?The text was updated successfully, but these errors were encountered: