fixup on replication status for crr

Author: benzekrimaha

lib/metadata/acl.js

@@ -36,31 +36,57 @@ const acl = {
     },
 
     addObjectACL(bucket, objectKey, objectMD, addACLParams, params, log, cb) {
-        log.trace('updating object acl in metadata');
-        const isAclUnchanged = Object.keys(objectMD.acl).length === Object.keys(addACLParams).length
-            && Object.keys(objectMD.acl).every(grant => this._aclGrantDidNotChange(grant, objectMD.acl, addACLParams));
+    log.trace('updating object acl in metadata');
+    const isAclUnchanged = Object.keys(objectMD.acl).length === Object.keys(addACLParams).length
+        && Object.keys(objectMD.acl).every(grant => this._aclGrantDidNotChange(grant, objectMD.acl, addACLParams));
         if (!isAclUnchanged) {
             /* eslint-disable no-param-reassign */
             objectMD.acl = addACLParams;
             objectMD.originOp = 's3:ObjectAcl:Put';
 
-            // Use storageType to determine if replication update is needed, as it is set only for
-            // "cloud" locations. This  ensures that we reset replication when CRR is used, but not
-            // when multi-backend replication (i.e. Zenko) is used.
-            // TODO: this should be refactored to properly update the replication info, accounting
-            // for multiple rules and resetting the status only if needed CLDSRV-646
             const replicationInfo = getReplicationInfo(config, objectKey, bucket, true);
-            if (replicationInfo && !replicationInfo.storageType) {
-                objectMD.replicationInfo = {
-                    ...objectMD.replicationInfo,
-                    ...replicationInfo,
-                };
+            
+            // Split the storageClass and iterate over each one
+            if (replicationInfo) {
+                const storageClasses = replicationInfo.storageClass ? replicationInfo.storageClass.split(',') : [];
+                const crrStorageClasses = [];
+                const crrBackends = [];
+                
+                // Iterate over each storage class and check isCRR
+                storageClasses.forEach((storageClass, index) => {
+                    const trimmedStorageClass = storageClass.trim();
+                    if (config.locationConstraints && 
+                        config.locationConstraints[trimmedStorageClass] && 
+                        config.locationConstraints[trimmedStorageClass].isCRR) {
+                        // This storage class has CRR enabled, include it
+                        crrStorageClasses.push(trimmedStorageClass);
+                        
+                        // Include corresponding backend if it exists
+                        if (replicationInfo.backends && replicationInfo.backends[index]) {
+                            crrBackends.push(replicationInfo.backends[index]);
+                        }
+                    }
+                });
+                
+                // Only set replication info for storage classes that have isCRR = true
+                if (crrStorageClasses.length > 0) {
+                    const filteredReplicationInfo = {
+                        ...replicationInfo,
+                        storageClass: crrStorageClasses.join(','),
+                        backends: crrBackends
+                    };
+                    
+                    objectMD.replicationInfo = {
+                        ...objectMD.replicationInfo,
+                        ...filteredReplicationInfo,
+                    };
+                }
             }
 
             return metadata.putObjectMD(bucket.getName(), objectKey, objectMD, params, log, cb);
         }
         return cb();
-    },
+    }
 
     parseAclFromHeaders(params, cb) {
         const headers = params.headers;