update variable name

Will Toozs · Will Toozs · commit a7ce187499da · 2023-09-18T18:31:12.000+02:00
diff --git a/lib/api/bucketDelete.js b/lib/api/bucketDelete.js
@@ -31,7 +31,7 @@ function bucketDelete(authInfo, request, log, cb) {
         request,
     };
 
-    return metadataValidateBucket(metadataValParams, request.iamAuthzResults, log,
+    return metadataValidateBucket(metadataValParams, request.actionImplicitDenies, log,
         (err, bucketMD) => {
             const corsHeaders = collectCorsHeaders(request.headers.origin,
                 request.method, bucketMD);
diff --git a/lib/api/bucketDeleteCors.js b/lib/api/bucketDeleteCors.js
@@ -34,7 +34,7 @@ function bucketDeleteCors(authInfo, request, log, callback) {
         log.trace('found bucket in metadata');
 
         if (!isBucketAuthorized(bucket, requestType, canonicalID, authInfo,
-            request.iamAuthzResults, log, request)) {
+            request.actionImplicitDenies, log, request)) {
             log.debug('access denied for user on bucket', {
                 requestType,
                 method: 'bucketDeleteCors',
diff --git a/lib/api/bucketDeleteEncryption.js b/lib/api/bucketDeleteEncryption.js
@@ -26,7 +26,7 @@ function bucketDeleteEncryption(authInfo, request, log, callback) {
     };
 
     return async.waterfall([
-        next => metadataValidateBucket(metadataValParams, request.iamAuthzResults, log, next),
+        next => metadataValidateBucket(metadataValParams, request.actionImplicitDenies, log, next),
         (bucket, next) => checkExpectedBucketOwner(request.headers, bucket, log, err => next(err, bucket)),
         (bucket, next) => {
             const sseConfig = bucket.getServerSideEncryption();
diff --git a/lib/api/bucketDeleteLifecycle.js b/lib/api/bucketDeleteLifecycle.js
@@ -20,7 +20,7 @@ function bucketDeleteLifecycle(authInfo, request, log, callback) {
         requestType: 'bucketDeleteLifecycle',
         request,
     };
-    return metadataValidateBucket(metadataValParams, request.iamAuthzResults, log, (err, bucket) => {
+    return metadataValidateBucket(metadataValParams, request.actionImplicitDenies, log, (err, bucket) => {
         const corsHeaders = collectCorsHeaders(headers.origin, method, bucket);
         if (err) {
             log.debug('error processing request', {
diff --git a/lib/api/bucketDeletePolicy.js b/lib/api/bucketDeletePolicy.js
@@ -19,7 +19,7 @@ function bucketDeletePolicy(authInfo, request, log, callback) {
         requestType: 'bucketDeletePolicy',
         request,
     };
-    return metadataValidateBucket(metadataValParams, request.iamAuthzResults, log, (err, bucket) => {
+    return metadataValidateBucket(metadataValParams, request.actionImplicitDenies, log, (err, bucket) => {
         const corsHeaders = collectCorsHeaders(headers.origin, method, bucket);
         if (err) {
             log.debug('error processing request', {
diff --git a/lib/api/bucketDeleteReplication.js b/lib/api/bucketDeleteReplication.js
@@ -20,7 +20,7 @@ function bucketDeleteReplication(authInfo, request, log, callback) {
         requestType: 'bucketDeleteReplication',
         request,
     };
-    return metadataValidateBucket(metadataValParams, request.iamAuthzResults, log, (err, bucket) => {
+    return metadataValidateBucket(metadataValParams, request.actionImplicitDenies, log, (err, bucket) => {
         const corsHeaders = collectCorsHeaders(headers.origin, method, bucket);
         if (err) {
             log.debug('error processing request', {
diff --git a/lib/api/bucketDeleteWebsite.js b/lib/api/bucketDeleteWebsite.js
@@ -26,7 +26,7 @@ function bucketDeleteWebsite(authInfo, request, log, callback) {
         log.trace('found bucket in metadata');
 
         if (!isBucketAuthorized(bucket, requestType, canonicalID, authInfo,
-            request.iamAuthzResults, log, request)) {
+            request.actionImplicitDenies, log, request)) {
             log.debug('access denied for user on bucket', {
                 requestType,
                 method: 'bucketDeleteWebsite',
diff --git a/lib/api/multiObjectDelete.js b/lib/api/multiObjectDelete.js
@@ -505,7 +505,7 @@ function multiObjectDelete(authInfo, request, log, callback) {
                         bucketMD);
                 }
                 if (!isBucketAuthorized(bucketMD, 'objectDelete', canonicalID, authInfo,
-                    request.iamAuthzResults, log, request)) {
+                    request.actionImplicitDenies, log, request)) {
                     log.trace("access denied due to bucket acl's");
                     // if access denied at the bucket level, no access for
                     // any of the objects so all results will be error results
diff --git a/lib/api/objectDelete.js b/lib/api/objectDelete.js
@@ -56,7 +56,7 @@ function objectDelete(authInfo, request, log, cb) {
     const canonicalID = authInfo.getCanonicalID();
     return async.waterfall([
         function validateBucketAndObj(next) {
-            return metadataValidateBucketAndObj(valParams, request.iamAuthzResults, log,
+            return metadataValidateBucketAndObj(valParams, request.actionImplicitDenies, log,
                 (err, bucketMD, objMD) => {
                 if (err) {
                     return next(err, bucketMD);
diff --git a/lib/api/objectDeleteTagging.js b/lib/api/objectDeleteTagging.js
@@ -46,7 +46,7 @@ function objectDeleteTagging(authInfo, request, log, callback) {
     };
 
     return async.waterfall([
-        next => metadataValidateBucketAndObj(metadataValParams, request.iamAuthzResults, log,
+        next => metadataValidateBucketAndObj(metadataValParams, request.actionImplicitDenies, log,
           (err, bucket, objectMD) => {
               if (err) {
                   log.trace('request authorization failed',
diff --git a/tests/unit/api/bucketDelete.js b/tests/unit/api/bucketDelete.js
@@ -87,7 +87,7 @@ describe('bucketDelete API', () => {
         namespace,
         headers: {},
         url: `/${bucketName}`,
-        iamAuthzResults: false,
+        actionImplicitDenies: false,
     };
 
     const initiateRequest = {
@@ -96,7 +96,7 @@ describe('bucketDelete API', () => {
         objectKey: objectName,
         headers: { host: `${bucketName}.s3.amazonaws.com` },
         url: `/${objectName}?uploads`,
-        iamAuthzResults: false,
+        actionImplicitDenies: false,
     };
 
     it('should return an error if the bucket is not empty', done => {
diff --git a/tests/unit/api/bucketDeleteCors.js b/tests/unit/api/bucketDeleteCors.js
@@ -19,7 +19,7 @@ const testBucketPutRequest = {
     bucketName,
     headers: { host: `${bucketName}.s3.amazonaws.com` },
     url: '/',
-    iamAuthzResults: false,
+    actionImplicitDenies: false,
 };
 const testBucketPutCorsRequest =
     corsUtil.createBucketCorsRequest('PUT', bucketName);
diff --git a/tests/unit/api/bucketDeleteEncryption.js b/tests/unit/api/bucketDeleteEncryption.js
@@ -13,7 +13,7 @@ const bucketPutRequest = {
     bucketName,
     headers: { host: `${bucketName}.s3.amazonaws.com` },
     url: '/',
-    iamAuthzResults: false,
+    actionImplicitDenies: false,
 };
 describe('bucketDeleteEncryption API', () => {
     before(() => cleanup());
diff --git a/tests/unit/api/bucketDeleteLifecycle.js b/tests/unit/api/bucketDeleteLifecycle.js
@@ -19,7 +19,7 @@ function _makeRequest(includeXml) {
         bucketName,
         headers: { host: `${bucketName}.s3.amazonaws.com` },
         url: '/',
-        iamAuthzResults: false,
+        actionImplicitDenies: false,
     };
     if (includeXml) {
         request.post = '<LifecycleConfiguration ' +
diff --git a/tests/unit/api/bucketDeletePolicy.js b/tests/unit/api/bucketDeletePolicy.js
@@ -19,7 +19,7 @@ function _makeRequest(includePolicy) {
         bucketName,
         headers: { host: `${bucketName}.s3.amazonaws.com` },
         url: '/',
-        iamAuthzResults: false,
+        actionImplicitDenies: false,
     };
     if (includePolicy) {
         const examplePolicy = {
diff --git a/tests/unit/api/bucketDeleteWebsite.js b/tests/unit/api/bucketDeleteWebsite.js
@@ -20,7 +20,7 @@ const testBucketPutRequest = {
     bucketName,
     headers: { host: `${bucketName}.s3.amazonaws.com` },
     url: '/',
-    iamAuthzResults: false,
+    actionImplicitDenies: false,
 };
 const testBucketDeleteWebsiteRequest = {
     bucketName,
@@ -29,7 +29,7 @@ const testBucketDeleteWebsiteRequest = {
     },
     url: '/?website',
     query: { website: '' },
-    iamAuthzResults: false,
+    actionImplicitDenies: false,
 };
 const testBucketPutWebsiteRequest = Object.assign({ post: config.getXml() },
     testBucketDeleteWebsiteRequest);
diff --git a/tests/unit/api/objectDeleteTagging.js b/tests/unit/api/objectDeleteTagging.js
@@ -22,7 +22,7 @@ const testBucketPutRequest = {
     bucketName,
     headers: { host: `${bucketName}.s3.amazonaws.com` },
     url: '/',
-    iamAuthzResults: false,
+    actionImplicitDenies: false,
 };
 
 const testPutObjectRequest = new DummyRequest({

Original file line number	Diff line number	Diff line change
`@@ -505,7 +505,7 @@ function multiObjectDelete(authInfo, request, log, callback) {`
`505`	`505`	`bucketMD);`
`506`	`506`	`}`
`507`	`507`	`if (!isBucketAuthorized(bucketMD, 'objectDelete', canonicalID, authInfo,`
`508`		`- request.iamAuthzResults, log, request)) {`
	`508`	`+ request.actionImplicitDenies, log, request)) {`
`509`	`509`	`log.trace("access denied due to bucket acl's");`
`510`	`510`	`// if access denied at the bucket level, no access for`
`511`	`511`	`// any of the objects so all results will be error results`