Skip to content

Bugs in the latest version. #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hevet opened this issue Feb 5, 2025 · 11 comments
Open

Bugs in the latest version. #623

hevet opened this issue Feb 5, 2025 · 11 comments

Comments

@hevet
Copy link

hevet commented Feb 5, 2025

@schreibfaul1 Hi. I found a few errors, typos.

Lines in main.cpp file 2129, 2223, 2249, 2327 are .pngg file format instead of .png

Icon in btn/s - Button_Up_Magenta.png is too small, it is 30x30 and should be 40x40.

Lines 2423-2424 is
btn_RA_bt.show();
btn_RA_off.show(!_f_BtEmitterFound);
should be
btn_RA_bt.show(!_f_BtEmitterFound);
btn_RA_off.show();
otherwise after pressing ok on the remote control, the radio off icon will not appear in the icons menu.

@schreibfaul1
Copy link
Owner

To display a background image, I converted all buttons from jpg to png format. This was necessary because of the alpha channel which enables transparency. I think there will still be some errors. Many thanks for your contribution!

@hevet
Copy link
Author

hevet commented Feb 5, 2025

@schreibfaul1 :)

In main.cpp there is pic_BR_logo.setPicturePath("/common/Brightness.png"); which is why the background in the brightness menu is not displayed. On the card it is in .jpg.

The player does not refresh the number of the file being played, causing the numbers to overlap.

Image

schreibfaul1 added a commit that referenced this issue Feb 5, 2025
@schreibfaul1
Copy link
Owner

I had previously written the audio file number /sum directly on the display, but that no longer works so well, I have now used a text box. And absolutely right, Brightness is a jpg file.
The layout of Brightness doesn't look good, I have no idea how to improve it. But I have lowered the slider.
You don't need to take a photo of the display, just click on the graphic in the info area.

Image

@valera39
Copy link

valera39 commented Feb 5, 2025

Dear Wolle!
Sometimes the station flag icon disappears when changing the song being played. It reappears when you switch to a different station

@hevet
Copy link
Author

hevet commented Feb 6, 2025

I confirm, the flag is not displayed when we return to the clock and sleep timer settings.

schreibfaul1 added a commit that referenced this issue Feb 6, 2025
@schreibfaul1
Copy link
Owner

I hope the problem has now been solved.

@hevet
Copy link
Author

hevet commented Feb 12, 2025

@schreibfaul1 Hi. When dialing the station number from the remote control, the font got smaller, is this an intended effect or an error? 320x240 display.

Image

Bluetooth icons in .png are missing in the common/s folder.
BTnc.png, BTgold.png, BTblue.png, BToff.png

@schreibfaul1
Copy link
Owner

Thank you, I made a mistake. Now it's back the way it should be.

Image

@hevet
Copy link
Author

hevet commented Feb 24, 2025

@schreibfaul1
In file main.cpp is
if(btnNr == 10){btn_EQ_balance.showClickedPic(); _toneBAL = 0; txt_EQ_balance.writeText( "0"); sdr_EQ_balance.setValue(_toneLP); webSrv.send("settone=", setI2STone()); btn_EQ_balance.showAlternativePic();} if(btnNr == 20){btn_EQ_lowPass.showClickedPic(); _toneLP = 0; txt_EQ_lowPass.writeText( "0"); sdr_EQ_lowPass.setValue(_toneLP); webSrv.send("settone=", setI2STone()); btn_EQ_lowPass.showAlternativePic();} if(btnNr == 30){btn_EQ_bandPass.showClickedPic(); _toneBP = 0; txt_EQ_bandPass.writeText("0"); sdr_EQ_bandPass.setValue(_toneLP); webSrv.send("settone=", setI2STone()); btn_EQ_bandPass.showAlternativePic();} if(btnNr == 40){btn_EQ_highPass.showClickedPic(); _toneHP = 0; txt_EQ_highPass.writeText("0"); sdr_EQ_highPass.setValue(_toneLP); webSrv.send("settone=", setI2STone()); btn_EQ_highPass.showAlternativePic();}

and it should be

if(btnNr == 10){btn_EQ_balance.showClickedPic(); _toneBAL = 0; txt_EQ_balance.writeText( "0"); sdr_EQ_balance.setValue(_toneBAL); webSrv.send("settone=", setI2STone()); btn_EQ_balance.showAlternativePic();} if(btnNr == 20){btn_EQ_lowPass.showClickedPic(); _toneLP = 0; txt_EQ_lowPass.writeText( "0"); sdr_EQ_lowPass.setValue(_toneLP); webSrv.send("settone=", setI2STone()); btn_EQ_lowPass.showAlternativePic();} if(btnNr == 30){btn_EQ_bandPass.showClickedPic(); _toneBP = 0; txt_EQ_bandPass.writeText("0"); sdr_EQ_bandPass.setValue(_toneBP); webSrv.send("settone=", setI2STone()); btn_EQ_bandPass.showAlternativePic();} if(btnNr == 40){btn_EQ_highPass.showClickedPic(); _toneHP = 0; txt_EQ_highPass.writeText("0"); sdr_EQ_highPass.setValue(_toneHP); webSrv.send("settone=", setI2STone()); btn_EQ_highPass.showAlternativePic();}

@mogart
Copy link

mogart commented Feb 25, 2025 via email

@valera39
Copy link

Hi mogart! Check if you have all the necessary VSC extensions installed.
I'm perfectly capable of handling these
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants