Skip to content

TST test sample weight for NARX #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MatthewSZhang opened this issue Mar 31, 2025 · 0 comments · Fixed by #76
Closed

TST test sample weight for NARX #67

MatthewSZhang opened this issue Mar 31, 2025 · 0 comments · Fixed by #76
Assignees
@MatthewSZhang
Labels
enhancement New feature or request
Milestone
0.3.3

Comments

@MatthewSZhang
Copy link
Collaborator

MatthewSZhang commented Mar 31, 2025 •
edited
Loading

The sample weight of NARX cannot be checked by repeat or remove samples like scikit-learn does. Need specific test for it.

The sample weight only effect the loss function of narx. We can use static narx, which does not contain y and time delays, to test if the sample weight effect loss correctly by repeating or removing samples.
@MatthewSZhang MatthewSZhang added the enhancement New feature or request label Mar 31, 2025
@MatthewSZhang MatthewSZhang added this to the 0.3.3 milestone Mar 31, 2025
@MatthewSZhang MatthewSZhang self-assigned this Mar 31, 2025
@MatthewSZhang MatthewSZhang mentioned this issue Apr 11, 2025
Merged
3 tasks
@MatthewSZhang MatthewSZhang linked a pull request Apr 11, 2025 that will close this issue
TST add equivalence check for sample weights #76
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MatthewSZhang MatthewSZhang

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.3.3
Development

Successfully merging a pull request may close this issue.

TST add equivalence check for sample weights MatthewSZhang/fastcan
1 participant
@MatthewSZhang