Skip to content

Upgrade Cmd Removes All Files Including Virtual Environment #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks done
axif0 opened this issue Mar 25, 2025 · 6 comments
Open
2 tasks done

Upgrade Cmd Removes All Files Including Virtual Environment #596

axif0 opened this issue Mar 25, 2025 · 6 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@axif0
Copy link
Member

axif0 commented Mar 25, 2025

Terms

Behavior

Description

Running upgrade.py as,

scribe-data --upgrade

Removes all root files, including venv, instead of only updating necessary files which have changes in newer scribe version. Might be for this line, shutil.rmtree(Path.cwd() / item.name)

Expected behavior might be

  • Only update required files.

  • Preserve venv and other user-created files.

Also, add tests for upgrade.py.

Contribution

Happy to support this! I can also provide a review and check the PR once it's opened 😊

@andrewtavis andrewtavis added help wanted Extra attention is needed good first issue Good for newcomers labels Mar 26, 2025
@andrewtavis
Copy link
Member

Feel free to add labels and the tags for the Scribe Board to new issues, @axif0 :)

@meerhaasham1
Copy link
Contributor

Hello @andrewtavis
can I work on this

@andrewtavis
Copy link
Member

Sounds good, @meerhaasham1 :) Please let us know if you need any support!

@meerhaasham1
Copy link
Contributor

Hi @andrewtavis
Just to update you, I have completed the task of identifying the issue with the scribe-data --upgrade command.

I’ve made the necessary changes to ensure that the command now behaves as expected, updating only the required files while preserving the venv and other user-created files.

Currently, I’m working on writing test cases for test_upgrade.py to ensure everything is functioning correctly.

I’ll update you once the tests are ready, and the pull request is submitted.

Thanks

Image

@andrewtavis
Copy link
Member

Thanks for the update, @meerhaasham1! 😊

@meerhaasham1
Copy link
Contributor

Hi @andrewtavis,
Just a quick update — I’m currently working on the remaining issues related to “Add missing tests for files with low coverage” (#598).
Also, a gentle reminder that I’ve submitted a PR for issue #596 earlier and just wanted to follow up in case it might have been missed.
Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

3 participants