-
Notifications
You must be signed in to change notification settings - Fork 80
Upgrade Cmd Removes All Files Including Virtual Environment #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Feel free to add labels and the tags for the Scribe Board to new issues, @axif0 :) |
Hello @andrewtavis |
Sounds good, @meerhaasham1 :) Please let us know if you need any support! |
Hi @andrewtavis I’ve made the necessary changes to ensure that the command now behaves as expected, updating only the required files while preserving the Currently, I’m working on writing test cases for I’ll update you once the tests are ready, and the pull request is submitted. Thanks |
Thanks for the update, @meerhaasham1! 😊 |
… venv and user files, add tests
Hi @andrewtavis, |
Terms
Behavior
Description
Running upgrade.py as,
Removes all root files, including venv, instead of only updating necessary files which have changes in newer scribe version. Might be for this line,
shutil.rmtree(Path.cwd() / item.name)
Expected behavior might be
Only update required files.
Preserve venv and other user-created files.
Also, add tests for upgrade.py.
Contribution
Happy to support this! I can also provide a review and check the PR once it's opened 😊
The text was updated successfully, but these errors were encountered: