Skip to content

Commit 90829bd

Browse files
authored
feat: supports github apps - sso (#17)
1 parent da70618 commit 90829bd

File tree

4 files changed

+28
-14
lines changed

4 files changed

+28
-14
lines changed

sentry-db/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
name: sentry-db
33
description: A Helm chart for Kubernetes
44
type: application
5-
version: 0.7.0
5+
version: 0.8.0
66
appVersion: 10.0.0
77
dependencies:
88
- name: redis

sentry/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@ apiVersion: v2
22
name: sentry
33
description: A Helm chart for Kubernetes
44
type: application
5-
version: 0.7.0
5+
version: 0.8.0
66
appVersion: 10.0.0

sentry/templates/configmap-sentry.yaml

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,21 @@ data:
3535
3636
{{ if .Values.github.appId }}
3737
github-app.id: {{ .Values.github.appId }}
38+
{{ end }}
39+
{{ if .Values.github.appName }}
3840
github-app.name: "{{ .Values.github.appName }}"
39-
# github-app.webhook-secret: ""
40-
# github-app.private-key: ""
41+
{{ end }}
42+
{{ if .Values.github.privateKey }}
43+
github-app.private-key: |-
44+
{{ .Values.github.privateKey | nindent 8 }}"
45+
{{ end }}
46+
{{ if .Values.github.webhookSecret }}
47+
github-app.webhook-secret: "{{ .Values.github.webhookSecret }}"
48+
{{ end }}
49+
{{ if .Values.github.clientId }}
4150
github-app.client-id: "{{ .Values.github.clientId }}"
51+
{{ end }}
52+
{{ if .Values.github.clientSecret }}
4253
github-app.client-secret: "{{ .Values.github.clientSecret }}"
4354
{{ end }}
4455
@@ -307,11 +318,8 @@ data:
307318
# GitHub Integration #
308319
#####################
309320
310-
GITHUB_APP_ID = '{{ .Values.github.appId }}'
311-
GITHUB_API_SECRET = '{{ .Values.github.appSecret }}'
312-
# GITHUB_APP_ID = 'YOUR_GITHUB_APP_ID'
313-
# GITHUB_API_SECRET = 'YOUR_GITHUB_API_SECRET'
314-
# GITHUB_EXTENDED_PERMISSIONS = ['repo']
321+
GITHUB_APP_ID = '{{ .Values.githubSso.clientId }}'
322+
GITHUB_API_SECRET = '{{ .Values.githubSso.clientSecret }}'
315323
316324
#########################
317325
# Bitbucket Integration #

sentry/values.yaml

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -159,12 +159,18 @@ service:
159159
# - 192.168.0.1
160160
# loadBalancerSourceRanges: []
161161

162-
github: {}
162+
github: {} # https://github.com/settings/apps (Create a Github App)
163163
# github:
164-
# appId:
165-
# appName:
166-
# clientId:
167-
# clientSecret:
164+
# appId: "xxxx"
165+
# appName: MyAppName
166+
# clientId: "xxxxx"
167+
# clientSecret: "xxxxx"
168+
# privateKey: "-----BEGIN RSA PRIVATE KEY-----\nMIIEpA" !!!! Don't forget a trailing \n
169+
# webhookSecret: "xxxxx`"
170+
171+
githubSso: {} # https://github.com/settings/developers (Create a OAuth App)
172+
# clientId: "xx"
173+
# clientSecret: "xx"
168174

169175
slack: {}
170176
# slack:

0 commit comments

Comments
 (0)