Skip to content
This repository was archived by the owner on Oct 18, 2020. It is now read-only.
This repository was archived by the owner on Oct 18, 2020. It is now read-only.

Symlinks Fail for Directories #437

@anaxareian

Description

@anaxareian

I found and installed droppy years ago, and I was so happy with it, I never bothered to upgrade it.

In moving to a new VPS, I decided to upgrade, and although I like the ability to search, I really
miss the ability to symlink directories and not just files in the droppy client interface.

Will I break the world if I try and add this back by passing 'followSymlinks: true" to the rrdir factory method?

This feature made it very easy to have different web apps work seamlessly together by sharing their file system space via a symlink. I was shocked when I saw that it was claimed symlinks still worked, until I realized I should test them with a file. That worked like a charm, but then left me sad, feeling quite confident that it was not simply an error on my part leading to symlink directories showing up as executable files.

Interestingly enough, if the correct URL for the directory as a symlink is typed into the browser, and then a file added to that always empty in the droppy client directory, the file dropped will be uploaded to the symlinked directory. Unfortunately, I was not able to find anyway to actually see the contents of a symlinked directory.

os: debian 10 4.19.0-10-amd64 x86_64
droppy: 12.2.0
node: v12.18.3
npm: 6.14.6

droppy-directory-symlink-listing

The log after clicking on the "binary" file of the symlinked directorty:

Sep 15 00:43:27 lifeshar droppy[7835]: 2020-09-15 00:43:27 [INFO] 73.43.41.173:47484 GET /!/token [200] [17ms]
Sep 15 00:43:37 lifeshar droppy[7835]: 2020-09-15 00:43:37 [ERROR] Path provided was not a file!
Sep 15 00:43:37 lifeshar droppy[7835]: at isStatFile (/usr/local/lib/node_modules/droppy/node_modules/isbinaryfile/lib/index.js:150:15)
Sep 15 00:43:37 lifeshar droppy[7835]: at Object. (/usr/local/lib/node_modules/droppy/node_modules/isbinaryfile/lib/index.js:22:13)
Sep 15 00:43:37 lifeshar droppy[7835]: at Generator.next ()
Sep 15 00:43:37 lifeshar droppy[7835]: at fulfilled (/usr/local/lib/node_modules/droppy/node_modules/isbinaryfile/lib/index.js:5:58)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions