fix: assert type string is matched (#264)

simPod · web-flow · commit cdba36f2515d · 2024-10-09T14:30:15.000+02:00
diff --git a/src/Sql/Type.php b/src/Sql/Type.php
@@ -4,6 +4,7 @@
 
 namespace SimPod\ClickHouseClient\Sql;
 
+use function assert;
 use function preg_match;
 
 final readonly class Type
@@ -14,7 +15,8 @@ private function __construct(public string $name, public string $params)
 
     public static function fromString(string $type): self
     {
-        preg_match('~([a-zA-Z\d ]+)(?:\((.+)\))?~', $type, $matches);
+        $result = preg_match('~([a-zA-Z\d ]+)(?:\((.+)\))?~', $type, $matches);
+        assert($result === 1);
 
         return new self($matches[1], $matches[2] ?? '');
     }

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@`
`4`	`4`
`5`	`5`	`namespace SimPod\ClickHouseClient\Sql;`
`6`	`6`
	`7`	`+use function assert;`
`7`	`8`	`use function preg_match;`
`8`	`9`
`9`	`10`	`final readonly class Type`
`@@ -14,7 +15,8 @@ private function __construct(public string $name, public string $params)`
`14`	`15`
`15`	`16`	`public static function fromString(string $type): self`
`16`	`17`	`{`
`17`		`- preg_match('~([a-zA-Z\d ]+)(?:\((.+)\))?~', $type, $matches);`
	`18`	`+ $result = preg_match('~([a-zA-Z\d ]+)(?:\((.+)\))?~', $type, $matches);`
	`19`	`+ assert($result === 1);`
`18`	`20`
`19`	`21`	`return new self($matches[1], $matches[2] ?? '');`
`20`	`22`	`}`