Skip to content

Commit 0ddeb09

Browse files
author
Gonzalo Diaz
committed
[REFACTOR] [Github Actions] nodejs 24.x breaks jest. Avoiding 24.x versions.
1 parent af47480 commit 0ddeb09

File tree

2 files changed

+10
-45
lines changed

2 files changed

+10
-45
lines changed

.github/workflows/node-coverage.yml

Lines changed: 9 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,13 @@ on: # yamllint disable-line rule:truthy
55
push:
66
branches: ["main"]
77
pull_request:
8+
# The branches below must be a subset of the branches above
89
branches: ["main"]
910
workflow_dispatch:
1011

1112
jobs:
12-
build-and-test:
13-
name: Build, Lint & Test
13+
coverage:
14+
name: NodeJS CI Coverage
1415
runs-on: ubuntu-24.04
1516

1617
steps:
@@ -22,7 +23,7 @@ jobs:
2223
- name: Set up Node.js
2324
uses: actions/setup-node@v4
2425
with:
25-
node-version: 24.x
26+
node-version: 22.x
2627

2728
- name: Install dependencies
2829
run: npm ci --verbose
@@ -33,51 +34,15 @@ jobs:
3334
- name: Run the tests
3435
run: npm run jest:ci -- --coverage
3536

36-
# Subir cobertura como artifact para que otros jobs lo usen
37-
- name: Upload coverage artifact
38-
uses: actions/upload-artifact@v4
39-
with:
40-
name: coverage-report
41-
path: coverage # o la carpeta donde jest genera los reportes
42-
43-
44-
codecov:
45-
name: Upload to Codecov
46-
runs-on: ubuntu-24.04
47-
needs: build-and-test
48-
49-
steps:
50-
- name: Download coverage artifact
51-
uses: actions/download-artifact@v5
52-
with:
53-
name: coverage-report
54-
path: coverage
55-
56-
- name: Upload coverage reports to Codecov
37+
- name: Upload coverage reports to Codecov with GitHub Action
5738
uses: codecov/codecov-action@v5
5839
with:
59-
token: ${{ secrets.CODECOV_TOKEN }}
60-
verbose: true
61-
62-
sonarqube:
63-
name: Analyze with SonarQube
64-
runs-on: ubuntu-24.04
65-
needs: build-and-test
66-
67-
steps:
68-
- name: Checkout repository
69-
uses: actions/checkout@v5
70-
with:
71-
fetch-depth: 0
72-
73-
- name: Download coverage artifact
74-
uses: actions/download-artifact@v5
75-
with:
76-
name: coverage-report
77-
path: coverage
40+
token: ${{ secrets.CODECOV_TOKEN }} # required
41+
verbose: true # optional (default = false)
7842

79-
- name: SonarQube Scan
43+
- name: Analyze with SonarQube / SonarCloud
8044
uses: SonarSource/sonarqube-scan-action@master
8145
env:
8246
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
47+
# Needed to get PR information, if any
8348
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/node-test.js.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
strategy:
1818
matrix:
1919
os: ["ubuntu-24.04", "macos-14", "windows-2022"]
20-
node-version: [20.x, 22.x, 24.x]
20+
node-version: [18.x, 20.x, 22.x]
2121
# See supported Node.js release schedule
2222
# at https://nodejs.org/en/about/releases/
2323

0 commit comments

Comments
 (0)