Skip to content

SlevomatCodingStandard.TypeHints.DeclareStrictTypes and Squiz.Commenting.FileComment.SpacingAfterComment #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kkmuffme opened this issue Apr 29, 2025 · 0 comments

Comments

@kkmuffme
Copy link

	<rule ref="SlevomatCodingStandard.TypeHints.DeclareStrictTypes">
		<properties>
			<property name="declareOnFirstLine" value="false"/>
			<property name="linesCountBeforeDeclare" value="0"/>
			<property name="linesCountAfterDeclare" value="1"/>
			<property name="spacesCountAroundEqualsSign" value="0"/>
		</properties>
	</rule>

If I have a file like:

<?php
declare(strict_types=1);

echo 'hello';

This makes sense.
However if there is a PHPDoc

<?php
/**
 * foo
 */
declare(strict_types=1);

echo 'hello';

This will clash with Squiz.Commenting.FileComment.SpacingAfterComment and report an error
Maybe add an option <property name="linesCountBeforeDeclareAfterDocblock" value="1"/> to prevent this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants