Extraction naming consistency #93
AntonioSun
started this conversation in
Ideas
Replies: 1 comment 1 reply
-
Hi, the reason for that is the extract_json can have multiple expression and variables e.g. extract_json(variables: ['var_variable1', 'var_variable2'], expressions: ['$..author', '$..book']) but you if have only one variable and expression then you can use string only without [] extract_json(variables: 'var_variable', expressions: '$..author') I would agree that we can split it into two so you can use variable/expression if you have only one and variables/expressions if you have multiple. But yeah I don't have strong opinion in that. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I know this is kind of nitty-picky, but hear me out:
groovy-jmeter/src/test/groovy/net/simonix/dsl/jmeter/factory/extractor/ExtractorFactorySpec.groovy
Lines 30 to 32 in 07b89a2
I.e., both
extract_regex
andextract_jmes
usevariable
andexpression
.Yet,
extract_json
usesvariables
andexpressions
(both plural) instead.I just feel that the plurals here don't make much sense, and the naming is not consistent.
However, I do understand that you might have many legacy code done this way.
Beta Was this translation helpful? Give feedback.
All reactions