Skip to content

Commit feff8ac

Browse files
nrghoshdioptre
authored andcommitted
[serve.llm] fix: improve error handling for invalid model_id (ray-project#55589)
Signed-off-by: Nikhil Ghosh <[email protected]> Signed-off-by: Andrew Grosser <[email protected]>
1 parent d16fd5e commit feff8ac

File tree

1 file changed

+27
-5
lines changed

1 file changed

+27
-5
lines changed

python/ray/llm/_internal/serve/configs/server_models.py

Lines changed: 27 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -223,8 +223,16 @@ def _infer_supports_vision(self, model_id_or_path: str) -> None:
223223
attribute based on whether the config has `vision_config`. All LVM models has
224224
`vision_config` setup.
225225
"""
226-
hf_config = transformers.PretrainedConfig.from_pretrained(model_id_or_path)
227-
self._supports_vision = hasattr(hf_config, "vision_config")
226+
try:
227+
hf_config = transformers.PretrainedConfig.from_pretrained(model_id_or_path)
228+
self._supports_vision = hasattr(hf_config, "vision_config")
229+
except Exception as e:
230+
raise ValueError(
231+
f"Failed to load Hugging Face config for model_id='{model_id_or_path}'.\
232+
Ensure `model_id` is a valid Hugging Face repo or a local path that \
233+
contains a valid `config.json` file. "
234+
f"Original error: {repr(e)}"
235+
) from e
228236

229237
def _set_model_architecture(
230238
self,
@@ -236,9 +244,23 @@ def _set_model_architecture(
236244
attribute based on whether the config has `architectures`.
237245
"""
238246
if model_id_or_path:
239-
hf_config = transformers.PretrainedConfig.from_pretrained(model_id_or_path)
240-
if hasattr(hf_config, "architectures") and hf_config.architectures:
241-
self._model_architecture = hf_config.architectures[0]
247+
try:
248+
hf_config = transformers.PretrainedConfig.from_pretrained(
249+
model_id_or_path
250+
)
251+
if (
252+
hf_config
253+
and hasattr(hf_config, "architectures")
254+
and hf_config.architectures
255+
):
256+
self._model_architecture = hf_config.architectures[0]
257+
except Exception as e:
258+
raise ValueError(
259+
f"Failed to load Hugging Face config for model_id='{model_id_or_path}'.\
260+
Ensure `model_id` is a valid Hugging Face repo or a local path that \
261+
contains a valid `config.json` file. "
262+
f"Original error: {repr(e)}"
263+
) from e
242264

243265
if model_architecture:
244266
self._model_architecture = model_architecture

0 commit comments

Comments
 (0)