Migrate system tests to use GRPC V2 API #6696
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fasmat
requested review from
dshulyak,
poszu,
ivan4th,
jellonek and
kacpersaw
as code owners
|
bors try |
tryBuild failed: |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #6696 +/- ##
=========================================
- Coverage 76.9% 76.9% -0.1%
=========================================
Files 369 369
Lines 50315 50318 +3
=========================================
+ Hits 38734 38735 +1
- Misses 9374 9376 +2
Partials 2207 2207 ☔ View full report in Codecov by Sentry. |
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild failed: |
fasmat
force-pushed
the
migrate-systest-grpc-version
branch
from
15e6bcc to
174c4f7
Compare
fasmat
force-pushed
the
migrate-systest-grpc-version
branch
4 times, most recently
from
d90e154 to
c2a8152
Compare
fasmat
force-pushed
the
migrate-systest-grpc-version
branch
from
c2a8152 to
7c8831e
Compare
fasmat
force-pushed
the
migrate-systest-grpc-version
branch
from
7a38e33 to
8071b35
Compare
|
bors try |
tryBuild failed: |
fasmat
force-pushed
the
migrate-systest-grpc-version
branch
3 times, most recently
from
baf3c83 to
b8740c3
Compare
fasmat
force-pushed
the
migrate-systest-grpc-version
branch
from
0afa098 to
53dffb3
Compare
fasmat
force-pushed
the
migrate-systest-grpc-version
branch
from
53dffb3 to
cf3b7cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
System tests still use the v1 API. I migrated the tests to instead use the V2 API where possible.
Closes #6692
TODO: there appear to be issues with the v2beta1 and v2alpha1 APIs regarding streaming of layers. To avoid putting too much effort into this I'll put this into draft for now and will take another look later.
Description
All tests where migrated to use v2 APIs over v1 APIs. The only requests not yet migrated are proposal streams since those aren't available in v2 (and probably won't ever be). We should consider implementing those tests in a different way.
Test Plan
All system tests still pass as before.
TODO