Skip to content
This repository was archived by the owner on Jan 18, 2022. It is now read-only.

Commit 77999d4

Browse files
authored
Remove UTY-1578 workaround (#757)
* Remove UTY-1578 workaround, protocol logging works again on linux
1 parent df0d478 commit 77999d4

File tree

2 files changed

+1
-15
lines changed

2 files changed

+1
-15
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
- Fixed a bug where launching on Android from the Unity Editor would break if you have spaces in your project path.
1313
- Fixed a bug where a Unity package with no dependencies field in its `package.json` would cause code generation to throw exceptions.
14+
- Fixed a bug where protocol logging would crash Linux workers.
1415

1516
## `0.1.4` - 2019-01-28
1617

workers/unity/Packages/com.improbable.gdk.core/Worker/Worker.cs

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -135,11 +135,6 @@ public static async Task<Worker> CreateWorkerAsync(
135135
ConnectionParameters connectionParameters,
136136
ILogDispatcher logger, Vector3 origin)
137137
{
138-
// TODO: Remove when UTY-1578 is fixed.
139-
#if UNITY_STANDALONE_LINUX
140-
connectionParameters.EnableProtocolLoggingAtStartup = false;
141-
Debug.LogWarning("Automatically disabling protocol logging on Linux workers to prevent crashes.");
142-
#endif
143138
using (var connectionFuture =
144139
Connection.ConnectAsync(config.ReceptionistHost, config.ReceptionistPort, config.WorkerId,
145140
connectionParameters))
@@ -168,11 +163,6 @@ public static async Task<Worker> CreateWorkerAsync(
168163
ConnectionParameters connectionParameters,
169164
ILogDispatcher logger, Vector3 origin)
170165
{
171-
// TODO: Remove when UTY-1578 is fixed.
172-
#if UNITY_STANDALONE_LINUX
173-
connectionParameters.EnableProtocolLoggingAtStartup = false;
174-
Debug.LogWarning("Automatically disabling protocol logging on Linux workers to prevent crashes.");
175-
#endif
176166
using (var locator = new Locator(parameters.LocatorHost, parameters.LocatorParameters))
177167
{
178168
var deploymentList = await GetDeploymentList(locator);
@@ -211,11 +201,6 @@ public static async Task<Worker> CreateWorkerAsync(
211201
ConnectionParameters connectionParameters,
212202
ILogDispatcher logger, Vector3 origin)
213203
{
214-
// TODO: Remove when UTY-1578 is fixed.
215-
#if UNITY_STANDALONE_LINUX
216-
connectionParameters.EnableProtocolLoggingAtStartup = false;
217-
Debug.LogWarning("Automatically disabling protocol logging on Linux workers to prevent crashes.");
218-
#endif
219204
using (var locator = new AlphaLocator(parameters.LocatorHost, parameters.LocatorParameters))
220205
{
221206
using (var connectionFuture = locator.ConnectAsync(connectionParameters))

0 commit comments

Comments
 (0)