Added startup interceptors #1789
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool. I suggest adding some unit tests to demonstrate this functionality @ricardoboss. |
patriksvensson
requested changes
Apr 2, 2025
|
@FrankRay78 @patriksvensson I made the changes you asked for. This still needs to be documented and I think maybe an easier way to register it would be nice. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1788
Changes
Added a new interface
IStartupInterceptorthat is called before any command is executed. It can be registered using the type registrar and receives a context object, which also has access to the type registrar.I also added a property to the
ICommandContextso that it can access the type registrar.I know not all checkboxes above are checked and I know I didn't open a discussion first. I plan to still add documentation and tests. Since I'll open this as a draft, you can already give me feedback on the design before I do all the accompanying work.
Please upvote 👍 this pull request if you are interested in it.