fix scene properties issue, add on was compoletely broken after introducing class MeshExporterSettings(PropertyGroup)

speculative-artefact · speculative-artefact · commit 912ba86393d5 · 2025-04-12T14:56:02.000+02:00
diff --git a/__init__.py b/__init__.py
@@ -40,31 +40,44 @@
 
 def register():
     logger.info("Begin registration.")
-    # First register properties
+    # 1. Properties FIRST
     properties.register_properties()
-    
-    # Then register our classes
+    logger.info("Properties registered.")
+
+    # Debug code to verify registration
+    test = hasattr(bpy.types.Scene, "mesh_exporter")
+    logger.info(f"Verification - mesh_exporter exists: {test}")
+
+    # 2. Other Classes (Operators, Panels)
     for cls in classes:
         bpy.utils.register_class(cls)
-    
-    # Finally register export indicators (including the timer)
+    logger.info("Panel/Operator classes registered.")
+
+    # 3. Indicators
     export_indicators.register()
     logger.info("Export indicators registered.")
+    logger.info("Registration complete.")
 
 
 def unregister():
-    # First unregister export indicators (handles its own classes)
+    logger.info("Begin unregistration.")
+    # Unregister in REVERSE order
+
+    # 1. Indicators
     export_indicators.unregister()
-    
-    # Then unregister our other classes
+    logger.info("Export indicators unregistered.")
+
+    # 2. Other Classes
     for cls in reversed(classes):
         try:
             bpy.utils.unregister_class(cls)
         except RuntimeError as e:
-            print(f"Couldn't unregister {cls}: {e}")
-    
-    # Finally unregister properties
+            logger.error(f"Couldn't unregister {cls}: {e}")
+    logger.info("Panel/Operator classes unregistered.")
+
+    # 3. Properties LAST
     properties.unregister_properties()
+    logger.info("Properties unregistered.")
     logger.info("Unregistration complete.")
 
 
diff --git a/export_indicators.py b/export_indicators.py
@@ -76,15 +76,17 @@ def mark_object_as_exported(obj):
         
     # Ensure timer is registered
     if not bpy.app.timers.is_registered(update_timer_callback):
-        logger.warning("Export indicators timer not registered - registering now")
+        logger.warning("Export indicators timer not registered - "
+                       "registering now")
         try:
             bpy.app.timers.register(
                 update_timer_callback,
                 first_interval=_TIMER_INTERVAL_SECONDS,
                 persistent=True
             )
         except Exception as e:
-            logger.error(f"Failed to register timer in mark_object_as_exported: {e}")
+            logger.error(f"Failed to register timer in "
+                         f"mark_object_as_exported: {e}")
     
     # Mark the object
     obj[EXPORT_TIME_PROP] = time.time()
@@ -315,7 +317,9 @@ def update_all_export_statuses():
 
             elapsed_time = current_time - export_time
             old_status_val = obj.get(EXPORT_STATUS_PROP, ExportStatus.NONE.value)
-            old_status_name = ExportStatus(old_status_val).name if isinstance(old_status_val, int) else "UNKNOWN"
+            old_status_name = (ExportStatus(old_status_val).name 
+                               if isinstance(old_status_val, int) 
+                               else "UNKNOWN")
 
             new_status = ExportStatus.NONE
             if elapsed_time < FRESH_DURATION_SECONDS:
@@ -327,7 +331,8 @@ def update_all_export_statuses():
             
             # Only log when there's a status change
             if new_status_val != old_status_val:
-                status_changes.append((obj.name, old_status_name, new_status.name, elapsed_time))
+                status_changes.append((obj.name, old_status_name, 
+                                       new_status.name, elapsed_time))
                 needs_redraw = True
                 
                 # State transition logic
@@ -352,7 +357,8 @@ def update_all_export_statuses():
     
     # Log status changes together for easier debugging
     if status_changes:
-        logger.info(f"Status changes detected: {len(status_changes)} objects updated")
+        logger.info(f"Status changes detected: {len(status_changes)} "
+                    f"objects updated")
         for change in status_changes:
             name, old, new, elapsed = change
             logger.info(f"  → {name}: {old} → {new} (elapsed: {elapsed:.1f}s)")
@@ -392,7 +398,9 @@ def update_timer_callback():
         if status_updated:
             # More aggressive UI updating
             context = bpy.context
-            if context and hasattr(context, "window_manager") and context.window_manager:
+            if (context 
+                and hasattr(context, "window_manager") 
+                and context.window_manager):
                 for window in context.window_manager.windows:
                     if not hasattr(window, "screen") or not window.screen:
                         continue
@@ -403,7 +411,8 @@ def update_timer_callback():
                         except:
                             pass
             else:
-                logger.warning("Timer callback couldn't redraw: invalid context")
+                logger.warning("Timer callback couldn't redraw: "
+                               "invalid context")
     except Exception as e:
         # Log but don't stop the timer
         logger.error(f"[MESH_EXPORTER] Timer error: {e}", exc_info=True)
@@ -515,7 +524,8 @@ def register():
             first_interval=_TIMER_INTERVAL_SECONDS,
             persistent=True  # Make timer survive file loads
         )
-        logger.info(f"Export indicator timer registered (interval: {_TIMER_INTERVAL_SECONDS}s, persistent)")
+        logger.info(f"Export indicator timer registered (interval: "
+                    f"{_TIMER_INTERVAL_SECONDS}s, persistent)")
     except Exception as e:
         logger.error(f"Failed to register timer: {e}", exc_info=True)
 
diff --git a/operators.py b/operators.py
@@ -35,11 +35,22 @@
 
 @contextlib.contextmanager
 def temp_selection_context(context, active_object=None, selected_objects=None):
-    """Temporarily set the active object and selection using direct API."""
+    """
+    Temporarily set the active object and selection using direct API.
+    
+    Args:
+        context (bpy.context): The current Blender context.
+        active_object (bpy.types.Object, optional): 
+            The object to set as active.
+        selected_objects (list, optional): List of objects to select.
+    
+    Returns:
+        None
+    """
     # Store original state
     original_active = context.view_layer.objects.active
-    original_selected = [obj for obj in context.scene.objects if obj.select_get()]
-    original_mode = original_active.mode if original_active else 'OBJECT'
+    original_selected = [obj for obj in context.scene.objects 
+                         if obj.select_get()]
     
     try:
         # Deselect all objects directly
@@ -57,7 +68,8 @@ def temp_selection_context(context, active_object=None, selected_objects=None):
                     try:
                         obj.select_set(True)
                     except ReferenceError:
-                        logger.warning(f"Could not select '{obj.name}' - object reference invalid.")
+                        logger.warning(f"Could not select '{obj.name}' "
+                                       f"- object reference invalid.")
         
         # Set active object directly
         if active_object and active_object.name in context.scene.objects:
@@ -715,7 +727,7 @@ def poll(cls, context):
     def execute(self, context):
         """Runs the batch export process."""
         scene = context.scene
-        scene_props = scene
+        scene_props = scene.mesh_exporter
         wm = context.window_manager
         start_time = time.time()
 
@@ -945,11 +957,9 @@ def execute(self, context):
         """Executes the selection using direct API."""
         target_obj = bpy.data.objects.get(self.object_name)
         if not target_obj:
-            logger.warning(f"Object '{self.object_name}' not found for selection.")
+            logger.warning(f"Object '{self.object_name}' "
+                           f"not found for selection.")
             return {"CANCELLED"}
-
-        # Store original mode
-        original_mode = context.active_object.mode if context.active_object else 'OBJECT'
         
         # Deselect all objects directly
         for obj in context.scene.objects:
diff --git a/panels.py b/panels.py
@@ -91,7 +91,7 @@ def draw(self, context):
         col = layout.column(heading="Triangulate", align=True)
         col.prop(settings, "mesh_export_tri")
         sub = col.column(align=True)
-        # sub.enabled = context.scene.mesh_exporter.mesh_export_tri # Enable/disable sub-option
+        sub.enabled = settings.mesh_export_tri # Enable/disable sub-option
         sub.prop(settings, "mesh_export_tri_method")
         sub.prop(settings, "mesh_export_keep_normals")
 
@@ -135,7 +135,10 @@ def poll(cls, context):
         # Show only if the main panel exists and path is set
         settings = context.scene.mesh_exporter
         # Check if the path property itself exists and is not None/empty
-        return settings and settings.mesh_export_path is not None and settings.mesh_export_path != ""
+        return (settings 
+                and settings.mesh_export_path 
+                is not None 
+                and settings.mesh_export_path != "")
 
     def draw_header(self, context):
         layout = self.layout
@@ -149,7 +152,7 @@ def draw(self, context):
         layout.use_property_decorate = False
 
         # Enable/disable based on the header checkbox
-        # layout.enabled = context.scene.mesh_exporter.mesh_export_lod
+        layout.enabled = settings.mesh_export_lod
 
         col = layout.column(align=True)
         col.prop(settings, "mesh_export_lod_count")
diff --git a/properties.py b/properties.py
@@ -16,15 +16,15 @@ class MeshExporterSettings(PropertyGroup):
     # Export path property
     # Default to the current blend file directory 
     # with a subfolder "exported_meshes"
-    mesh_export_path = StringProperty(
+    mesh_export_path: StringProperty(
         name="Export Path",
         description="Path to export meshes",
         default="//exported_meshes/",
         subtype="DIR_PATH"
     )
 
     # Export format property
-    mesh_export_format = EnumProperty(
+    mesh_export_format: EnumProperty(
         name="Format",
         description="File format to export meshes",
         items=[
@@ -38,7 +38,7 @@ class MeshExporterSettings(PropertyGroup):
     )
 
     # Scale property
-    mesh_export_scale = FloatProperty(
+    mesh_export_scale: FloatProperty(
         name="Scale",
         description="Scale factor for exported meshes",
         default=1.0,
@@ -49,7 +49,7 @@ class MeshExporterSettings(PropertyGroup):
     )
 
     # Coordinate system properties
-    mesh_export_coord_up = EnumProperty(
+    mesh_export_coord_up: EnumProperty(
         name="Up Axis",
         description="Up axis for exported meshes",
         items=[
@@ -59,7 +59,7 @@ class MeshExporterSettings(PropertyGroup):
         default="Z"
     )
 
-    mesh_export_coord_forward = EnumProperty(
+    mesh_export_coord_forward: EnumProperty(
         name="Forward Axis",
         description="Forward axis for exported meshes",
         items=[
@@ -70,21 +70,21 @@ class MeshExporterSettings(PropertyGroup):
     )
 
     # Zero location property
-    mesh_export_zero_location = BoolProperty(
+    mesh_export_zero_location: BoolProperty(
         name="Zero Location",
         description="Zero location of the object copy before export",
         default=True
     )
 
     # Triangulate properties
-    mesh_export_tri = BoolProperty(
+    mesh_export_tri: BoolProperty(
         name="Triangulate Faces",
         description="Convert all faces to triangles on the copy",
         default=True
     )
 
     # Triangulate method property
-    mesh_export_tri_method = EnumProperty(
+    mesh_export_tri_method: EnumProperty(
         name="Method",
         description="Method used for triangulating quads",
         items=[
@@ -101,42 +101,42 @@ class MeshExporterSettings(PropertyGroup):
     )
 
     # Keep normals property
-    mesh_export_keep_normals = BoolProperty(
+    mesh_export_keep_normals: BoolProperty(
         name="Keep Normals",
         description="Preserve normal vectors during triangulation",
         default=True
     )
 
     # Prefix and suffix properties
-    mesh_export_prefix = StringProperty(
+    mesh_export_prefix: StringProperty(
         name="Prefix",
         description="Prefix for exported file names",
         default=""
     )
 
-    mesh_export_suffix = StringProperty(
+    mesh_export_suffix: StringProperty(
         name="Suffix",
         description="Suffix for exported file names",
         default=""
     )
 
     # LOD properties
-    mesh_export_lod = BoolProperty(
+    mesh_export_lod: BoolProperty(
         name="Generate LODs",
         description="Generate additional LODs using Decimate (modifies copy)",
         default=False
     )
 
     # LOD count property
-    mesh_export_lod_count = IntProperty(
+    mesh_export_lod_count: IntProperty(
         name="Additional LODs",
         description="How many additional LODs to generate (LOD1 to LOD4)",
         default=4, min=1, max=4, # Max 4 due to 4 ratio properties
     )
 
     # LOD type property
     # Note: I've excluded "UNSUBDIVIDE" and "DISSOLVE"
-    mesh_export_lod_type = EnumProperty(
+    mesh_export_lod_type: EnumProperty(
         name="Decimation Type",
         description="Type of decimation to use for generating LODs",
         items=[
@@ -148,22 +148,22 @@ class MeshExporterSettings(PropertyGroup):
     )
 
     # LOD ratio properties
-    mesh_export_lod_ratio_01 = FloatProperty(
+    mesh_export_lod_ratio_01: FloatProperty(
         name="LOD1 Ratio", 
         description="Decimate factor for LOD 1",
         default=0.75, min=0.0, max=1.0, subtype="FACTOR"
     )
-    mesh_export_lod_ratio_02 = FloatProperty(
+    mesh_export_lod_ratio_02: FloatProperty(
         name="LOD2 Ratio", 
         description="Decimate factor for LOD 2",
         default=0.50, min=0.0, max=1.0, subtype="FACTOR"
     )
-    mesh_export_lod_ratio_03 = FloatProperty(
+    mesh_export_lod_ratio_03: FloatProperty(
         name="LOD3 Ratio", 
         description="Decimate factor for LOD 3",
         default=0.25, min=0.0, max=1.0, subtype="FACTOR"
     )
-    mesh_export_lod_ratio_04 = FloatProperty(
+    mesh_export_lod_ratio_04: FloatProperty(
         name="LOD4 Ratio", 
         description="Decimate factor for LOD 4",
         default=0.10, min=0.0, max=1.0, subtype="FACTOR"
@@ -172,8 +172,18 @@ class MeshExporterSettings(PropertyGroup):
 
 def register_properties():
     """Register the property group and create the Scene property"""
-    bpy.utils.register_class(MeshExporterSettings)
-    bpy.types.Scene.mesh_exporter = PointerProperty(type=MeshExporterSettings)
+    try:
+        bpy.utils.register_class(MeshExporterSettings)
+        bpy.types.Scene.mesh_exporter = PointerProperty(
+            type=MeshExporterSettings)
+        # Verification
+        test = bpy.types.Scene.bl_rna.properties.get("mesh_exporter")
+        if test:
+            print(f"Successfully registered mesh_exporter: {test}")
+        else:
+            print("Failed to register mesh_exporter property")
+    except Exception as e:
+        print(f"Error registering properties: {e}")
 
 
 def unregister_properties():
