Allow 0 pct forwards to pass only in the client

Author: hkarani

components/adv-post-form.js

@@ -282,7 +282,7 @@ export default function AdvPostForm ({ children, item, sub, storageKeyPrefix })
                     name={`forward[${index}].pct`}
                     type='number'
                     step={5}
-                    min={1}
+                    min={0}
                     max={100}
                     append={<InputGroup.Text className='text-monospace'>%</InputGroup.Text>}
                     groupClassName={`${styles.percent} mb-0`}

lib/form.js

@@ -2,15 +2,15 @@ import { hasDeleteMention, hasReminderMention } from './item'
 
 /**
  * Normalize an array of forwards by converting the pct from a string to a number
- * Also extracts nym from nested user object, if necessary
+ * Also extracts nym from nested user object, if necessary and removes 0 pct fowards
  * @param {*} forward Array of forward objects ({nym?: string, pct: string, user?: { name: string } })
  * @returns normalized array, or undefined if not provided
  */
 export const normalizeForwards = (forward) => {
   if (!Array.isArray(forward)) {
     return undefined
   }
-  return forward.filter(fwd => fwd.nym || fwd.user?.name).map(fwd => ({ nym: fwd.nym ?? fwd.user?.name, pct: Number(fwd.pct) }))
+  return forward.filter(fwd => (fwd.nym || fwd.user?.name) && Number(fwd.pct) > 0).map(fwd => ({ nym: fwd.nym ?? fwd.user?.name, pct: Number(fwd.pct) }))
 }
 
 export const toastUpsertSuccessMessages = (toaster, upsertResponseData, dataKey, itemText) => {

lib/validate.js

@@ -145,7 +145,7 @@ export function advPostSchemaMembers ({ me, existingBoost = 0, ...args }) {
             },
             message: 'cannot forward to yourself'
           }),
-        pct: intValidator.required('must specify a percentage').min(1, 'percentage must be at least 1').max(100, 'percentage must not exceed 100')
+        pct: intValidator.required('must specify a percentage').min(0, 'percentage must be at least 0').max(100, 'percentage must not exceed 100')
       }))
       .compact((v) => !v.nym && !v.pct)
       .test({