Skip to content

Refactor index.html from HTML4 to HTML5 #4641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
Ubayed-Bin-Sufian opened this issue Apr 23, 2025 · 6 comments · Fixed by #4655
Closed
4 tasks done

Refactor index.html from HTML4 to HTML5 #4641

Ubayed-Bin-Sufian opened this issue Apr 23, 2025 · 6 comments · Fixed by #4655

Comments

@Ubayed-Bin-Sufian
Copy link
Contributor

Ubayed-Bin-Sufian commented Apr 23, 2025 •
edited
Loading

Current Behavior

The current index.html file is written using outdated HTML4 standards, lacking semantic structure and modern best practices. This affects maintainability, accessibility, and compatibility with modern browsers.

Desired Situation

Refactor index.html to follow HTML5 standards. This includes using semantic tags (like <header>, <nav>, <main>, <footer>), updating the document type declaration, and validating the file using the W3C HTML5 validator to ensure compliance.

Checklist

  • I have read and followed the project's code of conduct.
  • I have searched for similar issues before creating this one.
  • I have provided all the necessary information to understand and reproduce the issue.
  • I am willing to contribute to the resolution of this issue.

Thank you for contributing to our project! We appreciate your help in improving it.

📚 See contributing instructions.

🙋🏾🙋🏼 Questions: Community Matrix Server.

cc: @walterbender
@mohan-bee
Copy link
Contributor

@Ubayed-Bin-Sufian Let me take this !

@mohan-bee mohan-bee mentioned this issue Apr 24, 2025
Closed
chandan9410 added a commit to chandan9410/musicblocks that referenced this issue Apr 26, 2025
@chandan9410
Refactor index.html from HTML4 to HTML5, add semantic tags and update…
4577b2c 
… doctype (fixes sugarlabs#4641)
@Dishika18
Copy link

@Ubayed-Bin-Sufian If this issue hasn't been resolved yet, may I take it?

@Ubayed-Bin-Sufian
Copy link
Contributor Author

Ubayed-Bin-Sufian commented Apr 27, 2025 •
edited
Loading

@Ubayed-Bin-Sufian If this issue hasn't been resolved yet, may I take it?

Sure. I have provided some comments in this PR. Please follow them.

@TanmayBansa1 TanmayBansa1 mentioned this issue Apr 27, 2025
Merged
5 tasks
@TanmayBansa1
Copy link
Contributor

@Ubayed-Bin-Sufian ive solved this, the current PRs required a lot of changes on top of them as they were missing major code blocks, so raised a new PR.

@FirePheonix
Copy link
Contributor

Hmm, this is going to be a tough one ig.
There was earlier a PR which made changes in index.html which helped optimize SEOs a lot.
Remember that we also have to make sure the changes don't increase the loading time. In fact, I think switching to HTML5, if done correctly, might improves performance and SEO slightly.

@TanmayBansa1
Copy link
Contributor

@FirePheonix ive raised a PR, yes it does improve performance, the loading times are much lesser now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@TanmayBansa1 @Dishika18 @Ubayed-Bin-Sufian @mohan-bee @FirePheonix