-
Notifications
You must be signed in to change notification settings - Fork 48
Issue #144/pre commit implementation #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #144/pre commit implementation #150
Conversation
- Added "prepare" script to install husky hooks. - Configured lint-staged to run prettier and eslint checks on staged TypeScript and JavaScript files. - Updated package.json to include husky and lint-staged as devDependencies.
@shashi-sah2003 There are two errors in this PR:
Please address these issues :) |
|
Please fix them |
I tried and still facing the same issue |
@shashi-sah2003 please resolve conflicts with the upstream/main |
hey @omsuneri I have resolved the conflict |
hey @sa-fw-an it's really frustrating that you weren't able to reproduce. Could you pls give me your file for which you are trying to fail linting? |
Please open a new PR with Proper Implementation. |
name: Pull Request
about: Submit changes to the project for review and inclusion
NOTE: It is requested to everyone to do
npm install
after this merge.Description
I have implemented pre-commit hooks for this repo using husky so that it can check linting and prettier before committing into codebase
Related Issue
Fixes #144
Changes Made
package.json
for triggering ofnpx lint-staged
Testing Performed
Tested locally with bad formatting and it works perfect