fix(config): accept negative max terminated config to allow unlimited tracking

Signed-off-by: Sunil Thaha <[email protected]>

Author: sthaha

config/config.go

@@ -483,9 +483,7 @@ func (c *Config) Validate(skips ...SkipValidation) error {
 		if c.Monitor.Staleness < 0 {
 			errs = append(errs, fmt.Sprintf("invalid monitor staleness: %s can't be negative", c.Monitor.Staleness))
 		}
-		if c.Monitor.MaxTerminated < 0 {
-			errs = append(errs, fmt.Sprintf("invalid monitor max terminated: %d can't be negative", c.Monitor.MaxTerminated))
-		}
+
 		if c.Monitor.MinTerminatedEnergyThreshold < 0 {
 			errs = append(errs, fmt.Sprintf("invalid monitor min terminated energy threshold: %d can't be negative", c.Monitor.MinTerminatedEnergyThreshold))
 		}

config/config_test.go

@@ -633,7 +633,7 @@ func TestMonitorConfig(t *testing.T) {
 		assert.NoError(t, cfg.Validate())
 
 		cfg.Monitor.MaxTerminated = -10
-		assert.ErrorContains(t, cfg.Validate(), "invalid configuration: invalid monitor max terminated")
+		assert.NoError(t, cfg.Validate(), "invalid configuration: invalid monitor max terminated")
 
 		cfg.Monitor.MaxTerminated = 0
 		assert.NoError(t, cfg.Validate(), "maxTerminated=0 should be valid (unlimited)")
@@ -691,9 +691,9 @@ func TestMonitorConfigFlags(t *testing.T) {
 		args:     []string{"--monitor.max-terminated=0"},
 		expected: expect{interval: 5 * time.Second, staleness: 500 * time.Millisecond, maxTerminated: 0, parseError: nil},
 	}, {
-		name:     "invalid-max-terminated",
+		name:     "negative-max-terminated",
 		args:     []string{"--monitor.max-terminated=-10"},
-		expected: expect{cfgErr: fmt.Errorf("invalid configuration: invalid monitor max terminated")},
+		expected: expect{interval: 5 * time.Second, staleness: 500 * time.Millisecond, maxTerminated: -10, parseError: nil},
 	}}
 
 	for _, tc := range tt {
@@ -746,15 +746,15 @@ monitor:
 		assert.Equal(t, 0, cfg.Monitor.MaxTerminated)
 	})
 
-	t.Run("yaml-config-maxTerminated-invalid", func(t *testing.T) {
+	t.Run("yaml-config-maxTerminated-negative", func(t *testing.T) {
 		yamlData := `
 monitor:
   maxTerminated: -100
 `
 		reader := strings.NewReader(yamlData)
-		_, err := Load(reader)
-		assert.Error(t, err)
-		assert.Contains(t, err.Error(), "invalid monitor max terminated")
+		cfg, err := Load(reader)
+		assert.NoError(t, err)
+		assert.Equal(t, -100, cfg.Monitor.MaxTerminated)
 	})
 }